change bool to IterResult #538

bobzhang · 2024-06-11T08:14:58Z

change join
explicit iter result

coderabbitai · 2024-06-11T08:15:03Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coveralls · 2024-06-11T08:16:39Z

Pull Request Test Coverage Report for Build 1669

Details

2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 88.656%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
array/array.mbt	2	3	66.67%

Totals
Change from base Build 1668:	-0.02%
Covered Lines:	2626
Relevant Lines:	2962

💛 - Coveralls

coveralls · 2024-06-11T08:17:52Z

Pull Request Test Coverage Report for Build 1670

Details

2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 88.656%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
array/array.mbt	2	3	66.67%

Totals
Change from base Build 1668:	-0.02%
Covered Lines:	2626
Relevant Lines:	2962

💛 - Coveralls

…points

refactored all other as_iter

Co-authored-by: Bao Zhiyuan <[email protected]>

* 100% coverage for linklistmap * patch hash collision * patch format

* rename contain/member to contains * update readme

* rename forall/exists to all/any in sorted_set * update interface file * format code

* remove usage of Devec:: and do blackbox test for devec * fmt

refactored all other as_iter

… function

* 100% coverage for linklistmap * patch hash collision * patch format

* Update CONTRIBUTING.md * Update CONTRIBUTING.md

…)` (#593) * rename `make` to `new` in immut/hashmap * rename `make` to `new` in immut/hashset * add capacity optional argument in `devec.new`, remove `devec.with_capacity` * add `capacity` optional argument for Array::new, remove Array::with_capacity * continue tidy up (#592) * move Option::unwrap to builtin (#594) * with_capacity to new * Refactor devec test to use new method instead of with_capacity * add Buffer::new(~size_hint) --------- Co-authored-by: Hongbo Zhang <[email protected]> Co-authored-by: Yu Zhang <[email protected]> Co-authored-by: Neil-Chen <[email protected]>

refactored all other as_iter

* 100% coverage for linklistmap * patch hash collision * patch format

coveralls · 2024-06-24T10:34:58Z

Pull Request Test Coverage Report for Build 1893

Details

83 of 95 (87.37%) changed or added relevant lines in 17 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.08%) to 83.229%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
array/array.mbt	5	6	83.33%
array/fixedarray.mbt	2	3	66.67%
immut/hashmap/bucket.mbt	2	3	66.67%
immut/hashset/bucket.mbt	2	3	66.67%
immut/list/list.mbt	1	2	50.0%
queue/queue.mbt	1	2	50.0%
string/string.mbt	2	3	66.67%
builtin/iter.mbt	44	49	89.8%

Files with Coverage Reduction	New Missed Lines	%
builtin/linked_hash_map.mbt	1	98.9%

Totals
Change from base Build 1891:	0.08%
Covered Lines:	2938
Relevant Lines:	3530

💛 - Coveralls

coveralls · 2024-06-24T10:35:48Z

Pull Request Test Coverage Report for Build 1894

Details

83 of 95 (87.37%) changed or added relevant lines in 17 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 83.229%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
array/array.mbt	5	6	83.33%
array/fixedarray.mbt	2	3	66.67%
immut/hashmap/bucket.mbt	2	3	66.67%
immut/hashset/bucket.mbt	2	3	66.67%
immut/list/list.mbt	1	2	50.0%
queue/queue.mbt	1	2	50.0%
string/string.mbt	2	3	66.67%
builtin/iter.mbt	44	49	89.8%

Totals
Change from base Build 1891:	0.08%
Covered Lines:	2938
Relevant Lines:	3530

💛 - Coveralls

qazxcdswe123 · 2024-06-24T11:06:02Z

Accidentally ruined the commit history, but the diff should work just fine and the history should be cleaned after squash and merge.

coveralls · 2024-06-24T14:27:36Z

Pull Request Test Coverage Report for Build 1896

Details

83 of 95 (87.37%) changed or added relevant lines in 17 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 83.206%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
array/array.mbt	5	6	83.33%
array/fixedarray.mbt	2	3	66.67%
immut/hashmap/bucket.mbt	2	3	66.67%
immut/hashset/bucket.mbt	2	3	66.67%
immut/list/list.mbt	1	2	50.0%
queue/queue.mbt	1	2	50.0%
string/string.mbt	2	3	66.67%
builtin/iter.mbt	44	49	89.8%

Totals
Change from base Build 1895:	0.08%
Covered Lines:	2938
Relevant Lines:	3531

💛 - Coveralls

bobzhang added 2 commits June 11, 2024 16:14

change join

6b1a08c

explicit iter result

9448b9e

bobzhang changed the title ~~hongbo/iter result~~ [draft] hongbo/iter result Jun 11, 2024

fmt

3f69d1a

qazxcdswe123 added 5 commits June 20, 2024 14:40

refine comment

0494dca

Merge branch 'main' into hongbo/iter_result

08188c4

feat: Refactor iteration functions to use IterEnd and IterContinue

f821bfd

Refactor iteration functions to use until instead of to for range end…

202c07d

…points

license check

ddfcd59

bobzhang changed the title ~~[draft] hongbo/iter result~~ change bool to IterResult Jun 21, 2024

qazxcdswe123 and others added 17 commits June 24, 2024 17:33

rm iter_result_of_bool and bool_of_iter_result helper

3037ab2

refactored all other as_iter

no need for path (#584)

0fb986e

Co-authored-by: Bao Zhiyuan <[email protected]>

100% LinkedListMap coverage (#585)

1aaf79b

* 100% coverage for linklistmap * patch hash collision * patch format

rename contain/member to contains (#578)

935b43a

* rename contain/member to contains * update readme

rename forall/exists to all/any in sorted_set (#580)

aabb56d

* rename forall/exists to all/any in sorted_set * update interface file * format code

feat: add Option::or_default utility (#589)

d8bdd61

hongbo/tidy devec (#591)

39014a4

* remove usage of Devec:: and do blackbox test for devec * fmt

continue tidy up (#592)

3c7a9f3

move Option::unwrap to builtin (#594)

eee4298

explicit iter result

937742b

rm iter_result_of_bool and bool_of_iter_result helper

03ee95f

refactored all other as_iter

refactor: update Iter struct to use IterResult enum for internal make…

b59103e

… function

100% LinkedListMap coverage (#585)

2f53ba5

* 100% coverage for linklistmap * patch hash collision * patch format

Update CONTRIBUTING.md for naming conventions (#590)

acca063

* Update CONTRIBUTING.md * Update CONTRIBUTING.md

explicit iter result

d14d165

rm iter_result_of_bool and bool_of_iter_result helper

76b9430

refactored all other as_iter

Yu-zh and others added 5 commits June 24, 2024 18:28

move Option::unwrap to builtin (#594)

ed339db

100% LinkedListMap coverage (#585)

f4fc2b2

* 100% coverage for linklistmap * patch hash collision * patch format

move Option::unwrap to builtin (#594)

c45632b

Merge branch 'main' into hongbo/iter_result

ea25f34

fmt

9e67e02

Merge branch 'main' into hongbo/iter_result

b38d0eb

This was referenced Jun 25, 2024

change join #597

Merged

Explicit iter result #598

Merged

qazxcdswe123 closed this Jun 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change bool to IterResult #538

change bool to IterResult #538

bobzhang commented Jun 11, 2024

coderabbitai bot commented Jun 11, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 24, 2024 •

edited

Loading

coveralls commented Jun 24, 2024 •

edited

Loading

qazxcdswe123 commented Jun 24, 2024

coveralls commented Jun 24, 2024 •

edited

Loading

change bool to IterResult #538

change bool to IterResult #538

Conversation

bobzhang commented Jun 11, 2024

coderabbitai bot commented Jun 11, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1669

Details

💛 - Coveralls

coveralls commented Jun 11, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1670

Details

💛 - Coveralls

coveralls commented Jun 24, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1893

Details

💛 - Coveralls

coveralls commented Jun 24, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1894

Details

💛 - Coveralls

qazxcdswe123 commented Jun 24, 2024

coveralls commented Jun 24, 2024 • edited Loading

Pull Request Test Coverage Report for Build 1896

Details

💛 - Coveralls

CodeRabbit Configration File (`.coderabbit.yaml`)

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 11, 2024 •

edited

Loading

coveralls commented Jun 24, 2024 •

edited

Loading

coveralls commented Jun 24, 2024 •

edited

Loading

coveralls commented Jun 24, 2024 •

edited

Loading