-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] use Error type intead of Result #570
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
strconv/traits.mbt
Outdated
pub fn FromStr::from_string(str : String) -> Result[Bool, String] { | ||
parse_bool(str) | ||
impl FromStr for Bool with from_string(str){ | ||
parse_bool(str)! | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: maybe we should just call it Bool::from_string instead of parse_bool?
48864bc
to
1c27469
Compare
Known issues:
|
81d0195
to
1046766
Compare
cc @Yu-zh the Unify error is still there |
@bzy-debug do we have OCAMLRUNPARAM="b=1" setup properly so that backtrace is available (for bleeding version) |
436141c
to
a0f30de
Compare
a0f30de
to
9382821
Compare
No description provided.