Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use Error type intead of Result #570

Closed
wants to merge 7 commits into from
Closed

Conversation

bobzhang
Copy link
Contributor

No description provided.

Copy link
Contributor

coderabbitai bot commented Jun 18, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

pub fn FromStr::from_string(str : String) -> Result[Bool, String] {
parse_bool(str)
impl FromStr for Bool with from_string(str){
parse_bool(str)!
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: maybe we should just call it Bool::from_string instead of parse_bool?

@bobzhang bobzhang force-pushed the hongbo/use_error_instead branch from 48864bc to 1c27469 Compare June 20, 2024 03:53
@qazxcdswe123
Copy link
Contributor

qazxcdswe123 commented Jun 20, 2024

Known issues:

  1. strconv/traits.mbt test: Fatal error: exception Ctype.Unify
  2. json/json_test.mbt test stringify
Error: Failed to compile wasm module
Error when running~/.moon/lib/core/target/wasm-gc/debug/test/json/json.underscore_test.wasm: Failed to run the test

wasm-validate ~/.moon/lib/core/target/wasm-gc/debug/test/json/json.underscore_test.wasm
000000e: error: unexpected type form (got 0x50)

@bobzhang bobzhang force-pushed the hongbo/use_error_instead branch 2 times, most recently from 81d0195 to 1046766 Compare June 21, 2024 00:34
@bobzhang
Copy link
Contributor Author

cc @Yu-zh the Unify error is still there

@bobzhang
Copy link
Contributor Author

@bzy-debug do we have OCAMLRUNPARAM="b=1" setup properly so that backtrace is available (for bleeding version)

@bobzhang bobzhang force-pushed the hongbo/use_error_instead branch 2 times, most recently from 436141c to a0f30de Compare June 24, 2024 08:40
@bobzhang bobzhang force-pushed the hongbo/use_error_instead branch from a0f30de to 9382821 Compare June 25, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants