Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support native backend fs io #69

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat: support native backend fs io #69

merged 5 commits into from
Nov 5, 2024

Conversation

Young-Flash
Copy link
Collaborator

No description provided.

Copy link

peter-jerry-ye-code-review bot commented Oct 30, 2024

The provided git diff output reveals several changes and additions across multiple files, especially focusing on enhancing filesystem operations for different targets (native, wasm, js) and improving GitHub Actions workflows. Here are three significant observations:

  1. Enhanced GitHub Actions Workflow Configuration:

    • The workflow configuration in .github/workflows/check.yml has been updated to include a fail-fast: false strategy, which ensures that all jobs in the matrix run to completion, regardless of their success or failure. This is crucial for comprehensive testing and reporting.
    • Additionally, a step to set up MSVC (Microsoft Visual C++) has been added for Windows-latest environments, ensuring compatibility and proper setup for native builds on Windows.
  2. New Native FFI Implementation for Filesystem Operations:

    • A new file, benchmark/internal/ffi/ffi_native.mbt, has been introduced to handle native-target FFI (Foreign Function Interface) for timing operations. This includes placeholders for instant_now and instant_elapsed_as_secs_f64, suggesting the introduction of native performance timing capabilities.
    • Similarly, in the fs module, native FFI implementations (fs/internal/ffi/fs_native.mbt and fs/internal/ffi/native_stub.c) have been added to support filesystem operations natively, which is crucial for performance-critical applications.
  3. Documentation and Testing Improvements:

    • The fs.mbt file includes a new note in the create_dir function documentation, stating that nested directories are not supported for the native backend. This clarification is essential for developers working with the filesystem module, especially when targeting native platforms.
    • The fs_test.mbt file has been updated to improve testing of directory creation and removal, ensuring better coverage and reliability of the filesystem operations, especially concerning directory handling.

These changes collectively aim to improve the robustness, performance, and compatibility of the filesystem operations across different targets (native, wasm, js) and enhance the CI/CD pipeline using GitHub Actions.

@Young-Flash Young-Flash force-pushed the native_backend_io branch 4 times, most recently from 24d458b to dcaf676 Compare October 30, 2024 08:46
@Young-Flash Young-Flash marked this pull request as ready for review November 5, 2024 07:17
@Young-Flash Young-Flash merged commit 0a692f9 into main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant