Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix action pipeline not cancelling persistent tasks. #1782

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

milesj
Copy link
Collaborator

@milesj milesj commented Jan 5, 2025

No description provided.

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (ubuntu-latest, 20)

Total time: 1m 19s | Comparison time: 4m 52s | Estimated savings: 3m 32s (72.8% faster)

Action Time Status Info
🟩 SyncWorkspace 34.2ms Passed
🟩 SetupToolchain(node:~20) 22.9s Passed
🟩 SyncProject(node, visualizer) 6.2ms Passed
🟩 SyncProject(node, runtime) 7.4ms Passed
🟩 SyncProject(node, types) 8.4ms Passed
🟩 SyncProject(node, report) 3ms Passed
🟩 SyncProject(node, nx-compat) 4.4ms Passed
🟩 SyncProject(node, website) 6.4ms Passed
🟩 InstallWorkspaceDeps(node:~20) 44.1s Passed
🟦 RunTask(visualizer:lint) 803ms Cached
🟦 RunTask(types:lint) 1s Cached
🟩 RunTask(types:format) 1.2s Passed
🟦 RunTask(visualizer:build) 1.3s Cached
🟦 RunTask(visualizer:typecheck) 480.3ms Cached
🟦 RunTask(visualizer:test) 724.9ms Cached
🟦 RunTask(types:build) 608.8ms Cached
🟦 RunTask(types:typecheck) 524.8ms Cached
🟦 RunTask(types:test) 547.3ms Cached
🟩 RunTask(visualizer:format) 804.9ms Passed
🟦 RunTask(nx-compat:lint) 453.9ms Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:build) 441.7ms Cached
🟦 RunTask(report:lint) 443.5ms Cached
🟦 RunTask(nx-compat:test) 649.7ms Cached
🟩 RunTask(report:format) 830.4ms Passed
🟦 RunTask(report:typecheck) 438.8ms Cached
🟦 RunTask(nx-compat:build) 449.6ms Cached
🟦 RunTask(runtime:test) 523.8ms Cached
🟦 RunTask(report:build) 658ms Cached
🟦 RunTask(runtime:typecheck) 449.3ms Cached
🟩 RunTask(nx-compat:format) 835ms Passed
🟦 RunTask(nx-compat:typecheck) 430.4ms Cached
🟩 RunTask(runtime:format) 667.5ms Passed
🟦 RunTask(report:test) 495ms Cached
🟦 RunTask(website:lint) 472.4ms Cached
🟦 RunTask(runtime:lint) 526.8ms Cached
🟦 RunTask(website:build) 4.2s Cached
🟦 RunTask(website:test) 4.2s Cached
🟦 RunTask(website:typecheck) 4.4s Cached
🟩 RunTask(website:format) 8.1s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 20
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (ubuntu-latest, 22)

Total time: 1m 19s | Comparison time: 5m 13s | Estimated savings: 3m 54s (74.8% faster)

Action Time Status Info
🟩 SyncWorkspace 29.3ms Passed
🟩 SetupToolchain(node:~22) 24.3s Passed
🟩 SyncProject(node, visualizer) 4.7ms Passed
🟩 SyncProject(node, types) 5.6ms Passed
🟩 SyncProject(node, runtime) 6.1ms Passed
🟩 SyncProject(node, report) 3.6ms Passed
🟩 SyncProject(node, website) 5.2ms Passed
🟩 SyncProject(node, nx-compat) 4.5ms Passed
🟩 InstallWorkspaceDeps(node:~22) 41.5s Passed
🟦 RunTask(visualizer:test) 852.2ms Cached
🟦 RunTask(visualizer:lint) 1.1s Cached
🟦 RunTask(types:build) 1.2s Cached
🟩 RunTask(types:format) 1.3s Passed
🟦 RunTask(types:lint) 679.6ms Cached
🟩 RunTask(visualizer:format) 771.8ms Passed
🟦 RunTask(visualizer:build) 1s Cached
🟦 RunTask(types:typecheck) 1.1s Cached
🟦 RunTask(types:test) 941.9ms Cached
🟦 RunTask(visualizer:typecheck) 749.6ms Cached
🟦 RunTask(runtime:build) 622.2ms Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(nx-compat:lint) 612.5ms Cached
🟦 RunTask(nx-compat:test) 630.2ms Cached
🟦 RunTask(report:typecheck) 570.3ms Cached
🟦 RunTask(report:lint) 623.9ms Cached
🟦 RunTask(report:build) 587.6ms Cached
🟦 RunTask(nx-compat:build) 606ms Cached
🟦 RunTask(runtime:typecheck) 567.2ms Cached
🟩 RunTask(report:format) 902.1ms Passed
🟩 RunTask(nx-compat:format) 1s Passed
🟩 RunTask(runtime:format) 802.5ms Passed
🟦 RunTask(report:test) 569.5ms Cached
🟦 RunTask(nx-compat:typecheck) 718.6ms Cached
🟦 RunTask(runtime:lint) 637.7ms Cached
🟦 RunTask(runtime:test) 900.8ms Cached
🟦 RunTask(website:lint) 594.2ms Cached
🟦 RunTask(website:typecheck) 589.1ms Cached
🟦 RunTask(website:build) 5.6s Cached
🟦 RunTask(website:test) 5.6s Cached
🟩 RunTask(website:format) 8s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 22
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (ubuntu-latest, 18)

Total time: 1m 21s | Comparison time: 4m 23s | Estimated savings: 3m 2s (69.3% faster)

Action Time Status Info
🟩 SyncWorkspace 29ms Passed
🟩 SetupToolchain(node:~18) 23.2s Passed
🟩 SyncProject(node, runtime) 3.3ms Passed
🟩 SyncProject(node, visualizer) 4.3ms Passed
🟩 SyncProject(node, types) 3.1ms Passed
🟩 SyncProject(node, website) 5ms Passed
🟩 SyncProject(node, nx-compat) 3.1ms Passed
🟩 SyncProject(node, report) 3.1ms Passed
🟩 InstallWorkspaceDeps(node:~18) 44s Passed
🟦 RunTask(visualizer:lint) 754.4ms Cached
🟦 RunTask(types:lint) 1.1s Cached
🟦 RunTask(visualizer:test) 1.1s Cached
🟩 RunTask(types:format) 1.4s Passed
🟦 RunTask(types:test) 570.4ms Cached
🟩 RunTask(visualizer:format) 987.3ms Passed
🟦 RunTask(types:typecheck) 866.3ms Cached
🟦 RunTask(types:build) 623.9ms Cached
🟦 RunTask(visualizer:typecheck) 657.2ms Cached
🟦 RunTask(visualizer:build) 878.1ms Cached
🟦 RunTask(nx-compat:lint) 887.1ms Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:build) 635.4ms Cached
🟦 RunTask(nx-compat:test) 931.2ms Cached
🟦 RunTask(report:lint) 529.8ms Cached
🟩 RunTask(nx-compat:format) 842.8ms Passed
🟦 RunTask(report:typecheck) 787.7ms Cached
🟦 RunTask(nx-compat:build) 792.3ms Cached
🟦 RunTask(report:build) 565.1ms Cached
🟦 RunTask(runtime:typecheck) 535.1ms Cached
🟦 RunTask(runtime:test) 570.6ms Cached
🟩 RunTask(report:format) 883.6ms Passed
🟩 RunTask(runtime:format) 677.3ms Passed
🟦 RunTask(report:test) 537.6ms Cached
🟦 RunTask(runtime:lint) 756.6ms Cached
🟦 RunTask(nx-compat:typecheck) 848ms Cached
🟦 RunTask(website:lint) 715ms Cached
🟦 RunTask(website:typecheck) 549.3ms Cached
🟦 RunTask(website:test) 563.5ms Cached
🟦 RunTask(website:build) 5.1s Cached
🟩 RunTask(website:format) 8.8s Passed
Environment

OS: Linux
Matrix:

os = ubuntu-latest
node-version = 18
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (windows-latest, 20)

Total time: 1m 44s | Comparison time: 6m 32s | Estimated savings: 4m 48s (73.4% faster)

Action Time Status Info
🟩 SyncWorkspace 34.7ms Passed
🟩 SetupToolchain(node:~20) 26.9s Passed
🟩 SyncProject(node, visualizer) 13ms Passed
🟩 SyncProject(node, types) 12.9ms Passed
🟩 SyncProject(node, runtime) 16.5ms Passed
🟩 SyncProject(node, nx-compat) 5.3ms Passed
🟩 SyncProject(node, report) 5.7ms Passed
🟩 SyncProject(node, website) 4.4ms Passed
🟩 InstallWorkspaceDeps(node:~20) 1m Passed
🟦 RunTask(visualizer:test) 894.7ms Cached
🟦 RunTask(visualizer:typecheck) 1.3s Cached
🟦 RunTask(visualizer:lint) 1.3s Cached
🟦 RunTask(types:lint) 734.9ms Cached
🟩 RunTask(types:format) 1.9s Passed
🟦 RunTask(types:build) 850.2ms Cached
🟦 RunTask(visualizer:build) 1.2s Cached
🟦 RunTask(types:test) 1.1s Cached
🟦 RunTask(types:typecheck) 870.1ms Cached
🟦 RunTask(runtime:build) 732.4ms Cached
🟦 RunTask(report:lint) 710.8ms Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(nx-compat:test) 720.2ms Cached
🟩 RunTask(visualizer:format) 1.5s Passed
🟦 RunTask(report:typecheck) 705.2ms Cached
🟦 RunTask(nx-compat:build) 697.6ms Cached
🟦 RunTask(report:build) 710.4ms Cached
🟦 RunTask(runtime:typecheck) 633.6ms Cached
🟩 RunTask(report:format) 1.8s Passed
🟦 RunTask(runtime:test) 628.2ms Cached
🟩 RunTask(nx-compat:format) 1.9s Passed
🟩 RunTask(runtime:format) 1.7s Passed
🟦 RunTask(report:test) 647.8ms Cached
🟦 RunTask(nx-compat:typecheck) 944.9ms Cached
🟦 RunTask(nx-compat:lint) 880.7ms Cached
🟦 RunTask(runtime:lint) 971.8ms Cached
🟦 RunTask(website:typecheck) 757.2ms Cached
🟦 RunTask(website:build) 5.4s Cached
🟦 RunTask(website:lint) 5.4s Cached
🟦 RunTask(website:test) 5.4s Cached
🟩 RunTask(website:format) 10s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 20
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (windows-latest, 18)

Total time: 2m | Comparison time: 4m 58s | Estimated savings: 2m 57s (59.6% faster)

Action Time Status Info
🟩 SyncWorkspace 37.7ms Passed
🟩 SetupToolchain(node:~18) 32.8s Passed
🟩 SyncProject(node, types) 6.1ms Passed
🟩 SyncProject(node, visualizer) 6.9ms Passed
🟩 SyncProject(node, runtime) 7.2ms Passed
🟩 SyncProject(node, report) 5ms Passed
🟩 SyncProject(node, nx-compat) 5.2ms Passed
🟩 SyncProject(node, website) 5.7ms Passed
🟩 InstallWorkspaceDeps(node:~18) 1m 10s Passed
🟦 RunTask(visualizer:lint) 790.1ms Cached
🟦 RunTask(visualizer:typecheck) 1s Cached
🟦 RunTask(visualizer:test) 1s Cached
🟦 RunTask(types:lint) 506ms Cached
🟦 RunTask(types:build) 627.4ms Cached
🟦 RunTask(visualizer:build) 1.1s Cached
🟩 RunTask(types:format) 2.2s Passed
🟦 RunTask(types:typecheck) 720ms Cached
🟦 RunTask(types:test) 499.1ms Cached
🟦 RunTask(nx-compat:test) 664.5ms Cached
🟩 RunTask(visualizer:format) 1.8s Passed
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(runtime:build) 744.5ms Cached
🟦 RunTask(report:lint) 679.1ms Cached
🟦 RunTask(report:typecheck) 663.9ms Cached
🟦 RunTask(nx-compat:build) 672.8ms Cached
🟦 RunTask(report:build) 674.1ms Cached
🟦 RunTask(runtime:typecheck) 672.2ms Cached
🟦 RunTask(nx-compat:lint) 526.7ms Cached
🟩 RunTask(report:format) 1.9s Passed
🟦 RunTask(runtime:test) 570.2ms Cached
🟦 RunTask(report:test) 589.2ms Cached
🟩 RunTask(nx-compat:format) 2s Passed
🟩 RunTask(runtime:format) 1.8s Passed
🟦 RunTask(nx-compat:typecheck) 609.8ms Cached
🟦 RunTask(runtime:lint) 581.6ms Cached
🟦 RunTask(website:lint) 624.9ms Cached
🟦 RunTask(website:typecheck) 840ms Cached
🟦 RunTask(website:test) 573.9ms Cached
🟦 RunTask(website:build) 4.9s Cached
🟩 RunTask(website:format) 11.5s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 18
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

Copy link

github-actions bot commented Jan 5, 2025

Run report for 45975d07 (windows-latest, 22)

Total time: 1m 45s | Comparison time: 6m 33s | Estimated savings: 4m 47s (73.2% faster)

Action Time Status Info
🟩 SyncWorkspace 32.2ms Passed
🟩 SetupToolchain(node:~22) 29.3s Passed
🟩 SyncProject(node, types) 5.5ms Passed
🟩 SyncProject(node, visualizer) 6.7ms Passed
🟩 SyncProject(node, runtime) 7ms Passed
🟩 SyncProject(node, nx-compat) 4.6ms Passed
🟩 SyncProject(node, report) 4.4ms Passed
🟩 SyncProject(node, website) 5ms Passed
🟩 InstallWorkspaceDeps(node:~22) 59.4s Passed
🟦 RunTask(visualizer:typecheck) 828.5ms Cached
🟦 RunTask(visualizer:lint) 1.2s Cached
🟦 RunTask(visualizer:test) 1.2s Cached
🟦 RunTask(types:lint) 653.8ms Cached
🟩 RunTask(types:format) 2s Passed
🟦 RunTask(types:typecheck) 981.2ms Cached
🟩 RunTask(visualizer:format) 1.8s Passed
🟦 RunTask(types:build) 831ms Cached
🟦 RunTask(types:test) 796.6ms Cached
🟦 RunTask(visualizer:build) 1.4s Cached
🟦 RunTask(runtime:build) 1.2s Cached
And 19 more...
Expanded report
Action Time Status Info
🟦 RunTask(nx-compat:test) 1.2s Cached
🟦 RunTask(report:lint) 781ms Cached
🟩 RunTask(nx-compat:format) 1.4s Passed
🟦 RunTask(report:typecheck) 746.2ms Cached
🟦 RunTask(nx-compat:build) 752.5ms Cached
🟦 RunTask(report:build) 746.4ms Cached
🟦 RunTask(runtime:typecheck) 701.2ms Cached
🟦 RunTask(runtime:test) 781.4ms Cached
🟦 RunTask(nx-compat:typecheck) 620.3ms Cached
🟩 RunTask(report:format) 1.6s Passed
🟦 RunTask(report:test) 922.4ms Cached
🟩 RunTask(runtime:format) 1.4s Passed
🟦 RunTask(runtime:lint) 703.7ms Cached
🟦 RunTask(nx-compat:lint) 684.5ms Cached
🟦 RunTask(website:typecheck) 691.8ms Cached
🟦 RunTask(website:build) 5.3s Cached
🟦 RunTask(website:lint) 5s Cached
🟦 RunTask(website:test) 5.4s Cached
🟩 RunTask(website:format) 10.2s Passed
Environment

OS: Windows
Matrix:

os = windows-latest
node-version = 22
Touched files
.moon/workspace.yml
CHANGELOG.md
Cargo.lock
crates/action-pipeline/src/action_pipeline.rs
crates/cli/tests/run_test.rs
crates/remote/Cargo.toml
crates/remote/src/fs_digest.rs
crates/remote/src/http_remote_client.rs

@milesj milesj merged commit f08d017 into develop-1.31 Jan 6, 2025
26 of 27 checks passed
@milesj milesj deleted the 1.31-remote-http branch January 6, 2025 00:43
milesj added a commit that referenced this pull request Jan 6, 2025
* Update types.

* Fix pipeline cancel.

* Improve cancel.

* Check channel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant