docs(fields): BelongsToMany updated ->inLine method, ModelResources->Buttons updated with new methods, Import/Export added sugar for ->withConfirm() method #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2024 12:42
…modifyExportButton,getExportButton, modifyImportButton, getImportButton, modifyFiltersButton, getFiltersButton. Added images for these methods.
|
@DissNik немного обновил документацию, в данном ПР присутствуют изменения из ошибочно закрытого мною ПР. |
DissNik
reviewed
Jul 23, 2024
| @@ -250,6 +250,114 @@ public function getMassDeleteButton( | |||
| } // [tl! focus:-11] | |||
| </x-code> | |||
|
|
|||
| <x-sub-title id="mass-delete">Export button</x-sub-title> | |||
There was a problem hiding this comment.
id не правильный, и стоит добавить в меню эти пункты
| } // [tl! focus:-11] | ||
| </x-code> | ||
|
|
||
| <x-sub-title id="mass-delete">Import button</x-sub-title> |
There was a problem hiding this comment.
Тут тоже id нужно изменить чтоб из меню можно было перейти к этому разделу
| @@ -250,6 +250,114 @@ public function getMassDeleteButton( | |||
| } // [tl! focus:-11] | |||
| </x-code> | |||
|
|
|||
| <x-sub-title id="mass-delete">Кнопка экспорта</x-sub-title> | |||
| } // [tl! focus:-11] | ||
| </x-code> | ||
|
|
||
| <x-sub-title id="mass-delete">Кнопка импорта</x-sub-title> |
|
🤦 спасибо за замечания, не по глазам были id'шники ... поправил ru + en |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Сделал один небольшой ПР для обновления документации:
->inLine()поля BelongsToMany;modifyExportButton,getExportButton,modifyImportButton,getImportButton,modifyFiltersButton,getFiltersButtonв разделе ModelResources->Buttons;->withConfirm()для ExportHandler.