Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mip-b40 (LBTC listing) #464

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add mip-b40 (LBTC listing) #464

wants to merge 15 commits into from
+202 −1

Conversation

anajuliabit
Copy link
Collaborator

No description provided.

@anajuliabit anajuliabit changed the title Add mip-b38 Add mip-b38 (LBTC listing) Jan 17, 2025
ElliotFriedman
ElliotFriedman reviewed Jan 18, 2025
View reviewed changes
chains/8453.json
@@ -753,5 +753,10 @@
"addr": "0xdC7810B47eAAb250De623F0eE07764afa5F71ED1",
"isContract": true,
"name": "MOONWELL_WELL"
},
{
"addr": "0xecac9c5f704e954931349da37f60e39f515c11c1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTC token looks correct.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it as well.

ElliotFriedman
ElliotFriedman reviewed Jan 21, 2025
View reviewed changes
chains/8453.json
{
"addr": "0xb9059d6ace87b699e67ec750fe4399d29797d232",
"isContract": true,
"name": "CHAINLINK_LBTC_BTC_COMPOSITE_ORACLE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified this oracle uses the chainlink bounded redstone PoR oracle and chainlink btc/usd

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price feed looks correct.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 23, 2025 •
edited
Loading

Add mip-b40 (LBTC listing)

Generated at commit: 74191b81f0178db4562d001ab637d69dd8edc3bb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
4
0
12
45
64
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@anajuliabit anajuliabit changed the title Add mip-b38 (LBTC listing) Add mip-b40 (LBTC listing) Jan 23, 2025
@anajuliabit anajuliabit marked this pull request as ready for review January 23, 2025 21:15
lyoungblood
lyoungblood previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@lyoungblood lyoungblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

chains/8453.json
@@ -753,5 +753,10 @@
"addr": "0xdC7810B47eAAb250De623F0eE07764afa5F71ED1",
"isContract": true,
"name": "MOONWELL_WELL"
},
{
"addr": "0xecac9c5f704e954931349da37f60e39f515c11c1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it as well.

chains/8453.json
{
"addr": "0xb9059d6ace87b699e67ec750fe4399d29797d232",
"isContract": true,
"name": "CHAINLINK_LBTC_BTC_COMPOSITE_ORACLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price feed looks correct.

@anajuliabit
Copy link
Collaborator Author 


----------------- Proposal Actions ------------------

  1). Set supply caps MToken market
  target: 0xfBb21d0380beE3312B33c4353c8936a0F13EF26C
value: 0
payload:
  0x51a485e400000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000100000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000002363e7f00
  Proposal type: Base

  

  2). Set borrow caps MToken market
  target: 0xfBb21d0380beE3312B33c4353c8936a0F13EF26C
value: 0
payload:
  0x607ef6c100000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000100000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000e27f6600
  Proposal type: Base

  

  3). Set price feed for underlying address in MToken market
  target: 0xEC942bE8A8114bFD0396A5052c36027f2cA6a9d0
value: 0
payload:
  0x0c607acf0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000b9059d6ace87b699e67ec750fe4399d29797d23200000000000000000000000000000000000000000000000000000000000000044c42544300000000000000000000000000000000000000000000000000000000
  Proposal type: Base

  

  4). Support MToken market in comptroller
  target: 0xfBb21d0380beE3312B33c4353c8936a0F13EF26C
value: 0
payload:
  0xa76b3fda00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee
  Proposal type: Base

  

  5). Temporal governor accepts admin on mToken
  target: 0x10fF57877b79e9bd949B3815220eC87B9fc5D2ee
value: 0
payload:
  0xe9c714f2
  Proposal type: Base

  

  6). Approve underlying token to be spent by market
  target: 0xecAc9C5F704e954931349Da37F60E39f515c11c1
value: 0
payload:
  0x095ea7b300000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee00000000000000000000000000000000000000000000000000000000000186a0
  Proposal type: Base

  

  7). Initialize token market to prevent exploit
  target: 0x10fF57877b79e9bd949B3815220eC87B9fc5D2ee
value: 0
payload:
  0xa0712d6800000000000000000000000000000000000000000000000000000000000186a0
  Proposal type: Base

  

  8). Send 1 wei to address 0 to prevent a state where market has 0 mToken
  target: 0x10fF57877b79e9bd949B3815220eC87B9fc5D2ee
value: 0
payload:
  0xa9059cbb00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001
  Proposal type: Base

  

  9). Check the market has been correctly initialized and collateral token minted
  target: 0xE9fFd686Ca83CeB308962f4e50c5Fd7F2E3c037e
value: 0
payload:
  0x3ec17c6b00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee
  Proposal type: Base

  

  10). Set Collateral Factor for MToken market in comptroller
  target: 0xfBb21d0380beE3312B33c4353c8936a0F13EF26C
value: 0
payload:
  0xe4028eee00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000000000000000000000000000000b3db2b55c110000
  Proposal type: Base

  

  11). Add emission config for MToken market in MultiRewardDistributor
  target: 0xe9005b078701e2A0948D2EaC43010D35870Ad9d2
value: 0
payload:
  0xea0f3dff00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000008b621804a7637b781e2bbd58e256a591f2df7d51000000000000000000000000a88594d404727625a9437c3f886c7643872296ae000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000067bb3b96
  Proposal type: Base

  

  12). Add emission config for MToken market in MultiRewardDistributor
  target: 0xe9005b078701e2A0948D2EaC43010D35870Ad9d2
value: 0
payload:
  0xea0f3dff00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000008b621804a7637b781e2bbd58e256a591f2df7d51000000000000000000000000833589fcd6edb6e08f4c7c32d4f71b54bda02913000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000067bb3b96
  Proposal type: Base

  

  

----------------- Proposal Calldata ------------------

  0x7d5e81e2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000f000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000c8e2b0cd52cf01b0ce87d389daa3d414d4ce29f300000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000d84b19a437e0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000006000000000000000000000000000000000000000000000000000000000000000c80000000000000000000000000000000000000000000000000000000000000d000000000000000000000000008b621804a7637b781e2bbd58e256a591f2df7d510000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000003c0000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000fbb21d0380bee3312b33c4353c8936a0f13ef26c000000000000000000000000fbb21d0380bee3312b33c4353c8936a0f13ef26c000000000000000000000000ec942be8a8114bfd0396a5052c36027f2ca6a9d0000000000000000000000000fbb21d0380bee3312b33c4353c8936a0f13ef26c00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000ecac9c5f704e954931349da37f60e39f515c11c100000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000e9ffd686ca83ceb308962f4e50c5fd7f2e3c037e000000000000000000000000fbb21d0380bee3312b33c4353c8936a0f13ef26c000000000000000000000000e9005b078701e2a0948d2eac43010d35870ad9d2000000000000000000000000e9005b078701e2a0948d2eac43010d35870ad9d2000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000018000000000000000000000000000000000000000000000000000000000000002800000000000000000000000000000000000000000000000000000000000000380000000000000000000000000000000000000000000000000000000000000044000000000000000000000000000000000000000000000000000000000000004a000000000000000000000000000000000000000000000000000000000000004e0000000000000000000000000000000000000000000000000000000000000056000000000000000000000000000000000000000000000000000000000000005c0000000000000000000000000000000000000000000000000000000000000064000000000000000000000000000000000000000000000000000000000000006a00000000000000000000000000000000000000000000000000000000000000720000000000000000000000000000000000000000000000000000000000000082000000000000000000000000000000000000000000000000000000000000000c451a485e400000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000100000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000002363e7f000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c4607ef6c100000000000000000000000000000000000000000000000000000000000000400000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000100000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000e27f66000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000840c607acf0000000000000000000000000000000000000000000000000000000000000040000000000000000000000000b9059d6ace87b699e67ec750fe4399d29797d23200000000000000000000000000000000000000000000000000000000000000044c42544300000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024a76b3fda00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004e9c714f2000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044095ea7b300000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee00000000000000000000000000000000000000000000000000000000000186a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024a0712d6800000000000000000000000000000000000000000000000000000000000186a0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044a9059cbb000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000243ec17c6b00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044e4028eee00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000000000000000000000000000000b3db2b55c1100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c4ea0f3dff00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000008b621804a7637b781e2bbd58e256a591f2df7d51000000000000000000000000a88594d404727625a9437c3f886c7643872296ae000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000067bb3b960000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c4ea0f3dff00000000000000000000000010ff57877b79e9bd949b3815220ec87b9fc5d2ee0000000000000000000000008b621804a7637b781e2bbd58e256a591f2df7d51000000000000000000000000833589fcd6edb6e08f4c7c32d4f71b54bda02913000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000067bb3b9600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c4123204d49502d4234303a20416464204c425443204d61726b657420746f204d6f6f6e77656c6c206f6e20426173650a0a23232053756d6d6172790a0a546869732070726f706f73616c207365656b7320746f206f6e626f617264204c4254432c205b4c6f6d62617264e28099735d2868747470733a2f2f7777772e6c6f6d626172642e66696e616e63652f290a6c69717569642d7374616b656420426974636f696e20284c5354292c2061732061206e657720636f6c6c61746572616c206173736574206f6e204d6f6f6e77656c6ce280997320426173650a6465706c6f796d656e742e204c42544320636f6d62696e657320426974636f696ee2809973207365637572652c20646563656e7472616c697a65642073746f7265206f662076616c756520776974680a5b426162796c6f6ee28099735d2868747470733a2f2f626162796c6f6e6c6162732e696f2f2920506f53207969656c64206361706162696c69746965732c20756e6c6f636b696e67206e65770a6f70706f7274756e697469657320666f7220425443206c656e64696e6720616e6420626f72726f77696e672e2042792061637469766174696e672061206d61726b657420666f72204c425443206f6e0a426173652c2077652061696d20746f20737472656e677468656e20425443206c69717569646974792c20656e61626c65206c6576657261676564204c42544320706f736974696f6e732c20616e640a696e74726f64756365206c6f6f70696e67206f70706f7274756e697469657320776974682050656e646c6520505420746f6b656e732c206675727468657220656e68616e63696e670a656e676167656d656e742077697468204d6f6f6e77656c6c20616e64207468652062726f6164657220446546692065636f73797374656d2e204c425443e280997320696e746567726174696f6e2077696c6c0a616c6c6f77204d6f6f6e77656c6c20757365727320746f2062656e656669742066726f6d20426162796c6f6e20506f696e74732c204c6f6d62617264e2809973204c75782070726f6772616d2c20616e640a726f62757374206c697175696469747920696e204254432d706567676564206173736574732e205468697320737472617465676963206164646974696f6e20737570706f7274730a4d6f6f6e77656c6ce2809973206d697373696f6e20746f206272696e672074686520776f726c64206f6e636861696e207468726f75676820706f77657266756c2c2061636365737369626c6520446546690a746f6f6c732e20466f72206164646974696f6e616c2064657461696c732c20706c6561736520726576696577207468650a5b4c42544320746f6b656e20646f63756d656e746174696f6e5d2868747470733a2f2f646f63732e6c6f6d626172642e66696e616e6365292c0a5b44756e652064617368626f6172645d28747470733a2f2f64756e652e636f6d2f6c6f6d626172645f70726f746f636f6c2f6c6f6d62617264292c20616e640a5b4c425443206173736574206c697374696e6720666f72756d20706f73745d2868747470733a2f2f666f72756d2e6d6f6f6e77656c6c2e66692f742f6164642d6c6274632d746f2d6d6f6f6e77656c6c2d636f72652d6d61726b65742d6f6e2d626173652f313435342f292e0a0a232320546f6b656e20496e666f726d6174696f6e0a0a2d202a2a4e616d653a2a2a204c4254430a2d202a2a546f6b656e205374616e646172643a2a2a2045524332300a2d202a2a546f74616c20537570706c793a2a2a2031312c363030204c4254430a2d202a2a43697263756c6174696e6720537570706c79202842617365293a2a2a20312c3236332e3535204c4254430a2d202a2a546f6b656e20436f6e74726163743a2a2a0a20205b3078656341633943354637303465393534393331333439446133374636304533396635313563313163315d2868747470733a2f2f626173657363616e2e696f2f616464726573732f307865634163394335463730346539353439333133343944613337463630453339663531356331316331290a2d202a2a507269636520466565643a2a2a2052656473746f6e6520506f52204f7261636c6520284254432f4c4254432920c3970a20205b436861696e6c696e6b204254432f5553445d2868747470733a2f2f626173657363616e2e6f72672f616464726573732f307836346339313139393644336336614337316639623435354231453845373236364263624438343846290a0a2323204761756e746c65742773205269736b20416e616c7973697320616e64205265636f6d6d656e646174696f6e730a0a23232320496e697469616c205269736b20506172616d65746572730a0a7c202a2a506172616d657465722a2a202020202020202020207c202a2a56616c75652a2a207c0a7c202d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d2d207c202d2d2d2d2d2d2d2d2d207c0a7c20436f6c6c61746572616c20466163746f722028434629207c20383125202020202020207c0a7c20537570706c7920436170202020202020202020202020207c203935204c4254432020207c0a7c20426f72726f7720436170202020202020202020202020207c203338204c4254432020207c0a7c2050726f746f636f6c205365697a652053686172652020207c20333025202020202020207c0a7c205265736572766520466163746f722020202020202020207c20313025202020202020207c0a0a23232320496e7465726573742052617465204d6f64656c0a0a7c202a2a506172616d657465722a2a2020207c202a2a56616c75652a2a207c0a7c202d2d2d2d2d2d2d2d2d2d2d2d2d2d2d207c202d2d2d2d2d2d2d2d2d207c0a7c20426173652052617465202020202020207c20302520202020202020207c0a7c204d756c7469706c6965722020202020207c20372520202020202020207c0a7c204a756d70204d756c7469706c696572207c20327820202020202020207c0a7c204b696e6b2020202020202020202020207c20333525202020202020207c0a0a2323232320496e74657265737420526174652043757276650a0a7c202a2a5574696c697a6174696f6e2a2a207c202a2a426f72726f77204150522a2a207c202a2a537570706c79204150522a2a207c0a7c202d2d2d2d2d2d2d2d2d2d2d2d2d2d2d207c202d2d2d2d2d2d2d2d2d2d2d2d2d2d207c202d2d2d2d2d2d2d2d2d2d2d2d2d2d207c0a7c20302520202020202020202020202020207c203025202020202020202020202020207c203025202020202020202020202020207c0a7c2033352520284b696e6b292020202020207c20322e343525202020202020202020207c20302e373725202020202020202020207c0a7c20313030252020202020202020202020207c203133312e35252020202020202020207c203131382e34252020202020202020207c0a0a54686520696e74657265737420726174652063757276652066656174757265732061206b696e6b206174203335252c20656e737572696e6720636f6d7065746974697665207261746573207768696c650a696e63656e746976697a696e672062616c616e636564207574696c697a6174696f6e2e0a0a232320537570706f7274696e6720446174610a0a2d202a2a566f6c6174696c6974793a2a2a20416e6e75616c697a65642033302d646179206c6f6720766f6c6174696c697479206f6620302e393225207265666c65637473204c425443e280997320686967680a202070617269747920776974682069747320756e6465726c79696e67204254432e0a2d202a2a4c69717569646974793a2a2a204f6e2d636861696e206c697175696469747920737570706f7274732074726164696e6720757020746f203935204c4254432077697468203135250a2020736c6970706167652c2070726f766964696e672073756666696369656e742062756666657220666f7220737570706c7920636170732e0a0a232320566f74696e67204f7074696f6e730a0a2d202a2a4179653a2a2a20417070726f7665207468652070726f706f73616c20746f206163746976617465206120636f7265206c656e64696e67206d61726b657420666f72204c425443206f6e0a2020426173652077697468204761756e746c657427732073706563696669656420696e697469616c207269736b20706172616d65746572732e0a2d202a2a4e61793a2a2a2052656a656374207468652070726f706f73616c2e0a2d202a2a4162737461696e3a2a2a204162737461696e2066726f6d20766f74696e67206f6e20746869732070726f706f73616c2e0a00000000000000000000000000000000000000000000000000000000000000
```

@github-actions GitHub Actions
Copy link 

Compiling 4 files with Solc 0.8.19
Solc 0.8.19 finished in 8.51ms
Compiler run successful!
Script ran successfully.
Gas used: 35142933

If you wish to simulate on-chain transactions pass a RPC URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyoungblood lyoungblood Awaiting requested review from lyoungblood

@ElliotFriedman ElliotFriedman Awaiting requested review from ElliotFriedman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anajuliabit @lyoungblood @ElliotFriedman