Use ShiftClassInstaller to generate and update generated classes #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss definition instead of old class definition format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the ShiftClassBuilder to install or update classes instead of the old class definition.
It also factorize the code between installation and update of existing class in order to avoid to have two mechanisms.
I hope this will help unify P12 and P11
I tried also to use #update:to: instead of #make: in order to update real classes but I have some really really weird bugs :(
This would help use keep the class trait composition, the shared pools and other infos.
Maybe I could also try #fillFor: but I think Marcus is removing it from P12