Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Pharo code importing infrastructure #756

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

jecisc
Copy link
Member

@jecisc jecisc commented Apr 16, 2024

Here is a step at simplifying the Pharo code importers.

  • Merge some classes (classes with only one subclass)
  • Remove dead code
  • Factorize some code
  • Move classes in the right packages
  • Rename the importers to have more explicit names
  • Make File structure importer inherit from object

There are still improvements we can do but this PR is already big enough :)

@jecisc jecisc merged commit cb0951e into development Apr 16, 2024
2 of 4 checks passed
@jecisc jecisc deleted the clean-smalltalk-importers branch April 16, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant