chore: match every case in switch statements

file.go

@@ -174,7 +174,7 @@ func (f File) buildTransactions(recordHeader RecordHeader, currentLine *int) (st
 		ReturnCreditRecord:  make([]Transaction, 0),
 		ReturnDebitRecord:   make([]Transaction, 0),
 	}
-	for _, t := range f.Txns {
+	for idx, t := range f.Txns {
 		switch t.GetType() {
 		case DebitRecord:
 			recTypeToTxs[DebitRecord] = append(recTypeToTxs[DebitRecord], t)
@@ -188,6 +188,8 @@ func (f File) buildTransactions(recordHeader RecordHeader, currentLine *int) (st
 			recTypeToTxs[ReturnCreditRecord] = append(recTypeToTxs[ReturnCreditRecord], t)
 		case ReturnDebitRecord:
 			recTypeToTxs[ReturnDebitRecord] = append(recTypeToTxs[ReturnDebitRecord], t)
+		case HeaderRecord, NoticeOfChangeRecord, NoticeOfChangeHeader, NoticeOfChangeFooter, FooterRecord:
+			return "", fmt.Errorf("transaction[%d] has unexpected record type: %v", idx, t.GetType())
 		}
 	}
 	var sb strings.Builder
@@ -299,6 +301,8 @@ func NewTransaction(
 		txn = lo.ToPtr(NewCreditReverse(txnType, amount, date, institutionID, payorPayeeAccountNo, itemTraceNo, originatorShortName, payorPayeeName, originatorLongName, originalOrReturnInstitutionID, originalOrReturnAccountNo, originalItemTraceNo, opts...))
 	case DebitReverseRecord:
 		txn = lo.ToPtr(NewDebitReverse(txnType, amount, date, institutionID, payorPayeeAccountNo, itemTraceNo, originatorShortName, payorPayeeName, originatorLongName, originalOrReturnInstitutionID, originalOrReturnAccountNo, originalItemTraceNo, opts...))
+	case HeaderRecord, NoticeOfChangeRecord, NoticeOfChangeHeader, NoticeOfChangeFooter, FooterRecord:
+		return nil
 	}
 	return txn
 }

file_streamer.go

@@ -2,6 +2,7 @@ package cadeft
 
 import (
 	"bufio"
+	"fmt"
 	"io"
 	"strings"
 
@@ -180,6 +181,8 @@ func (fs *FileStreamer) ScanTxn() (Transaction, error) {
 		if err := dr.Parse(txnsSegment[startIdx:endIdx]); err != nil {
 			return nil, newStreamParseError(err, string(DebitReverseRecord), fs.currentTxn, fs.currentLine)
 		}
+	case HeaderRecord, NoticeOfChangeRecord, NoticeOfChangeHeader, NoticeOfChangeFooter, FooterRecord:
+		return nil, fmt.Errorf("invalid record type: %v", recordType)
 	}
 	return txn, nil
 }

reader.go

@@ -2,6 +2,7 @@ package cadeft
 
 import (
 	"bufio"
+	"fmt"
 	"io"
 
 	"github.com/pkg/errors"
@@ -97,6 +98,8 @@ func (r *Reader) parseTxnRecord(data string) error {
 				return errors.Wrap(err, "failed to parse credit return transaction")
 			}
 			r.File.Txns = append(r.File.Txns, &creditReturns)
+		case HeaderRecord, FooterRecord, CreditReverseRecord, DebitReverseRecord, NoticeOfChangeRecord, NoticeOfChangeHeader, NoticeOfChangeFooter:
+			return fmt.Errorf("unexpected %s record", recType)
 		}
 		startIdx = endIdx
 		endIdx += segmentLength