Parsing ICL with image data #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2020 09:16
… should use to parse file. Add a secondary format X9100ascii to handle parsing ascii encoded ICLs without CRLF to indicate line breaks.
|
Awesome, thanks @jenakan! |
added 4 commits
October 9, 2020 13:21
…ngths rather than line breaks.
Only the file record count (Type 99; field 3) includes all record types. The bundle item count (Type 70; field 2), cash letter item count (Type 90; field 3) and file item count (Type 99; field 2) refer to the number of check records (type 25) or return records (type 31). These fields do not include headers, controls or addendums.
jenakan
force-pushed
the
parse-ascii-images
branch
from
7f1b91a
to
d7f9024
Compare
adamdecaf
reviewed
Oct 14, 2020
|
|
||
| const ( | ||
| // Discover format | ||
| Discover Format = iota |
There was a problem hiding this comment.
What if we renamed this to Detect? I'm worried Discover (the company) might have an X9 format we run into one day...
There was a problem hiding this comment.
@adamdecaf Thinking of dropping the Format enum. It's too restrictive.
DTSU can be read/written as ASCII, but FRB adoption of DTSU requires EBCDIC encoding. I'm making some changes to allow reading/writing with configurable options. It should allow more flexibility for others.
There was a problem hiding this comment.
Okay. We'll write up a matrix to explain the known combinations.
adamdecaf
approved these changes
Oct 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line length changes to support ASCII encoded ICLs with type(52) ImageData. Implemented a secondary format that will scan for lines based on control bytes defined by spec rather than CRLF line breaks.
Not sure if this counts as a format as mentioned in #111.