Skip to content

Commit

Permalink
Merge pull request #295 from mcook-moov/fix-deprecated-and-update-con…
Browse files Browse the repository at this point in the history
…tributing

Replace deprecated skip-dirs flag and update contributing.md
  • Loading branch information
adamdecaf authored May 10, 2024
2 parents eee4fbb + 89883cf commit 2c5ac41
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ A good quality PR will have the following characteristics:

A good PR should be able to flow through a peer review system easily and quickly.

Our Build pipeline utilizes [Travis-CI](https://travis-ci.org/moov-io/ach) to enforce many tools that you should add to your editor before issuing a pull request.
Our Build pipeline utilizes [GitHub Actions](https://github.com/moov-io/infra/actions) to enforce many tools that you should add to your editor before issuing a pull request.
5 changes: 3 additions & 2 deletions go/lint-project.sh
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ run:
timeout: 5m
tests: false
go: "$GO_VERSION"
skip-dirs:
issues:
exclude-dirs:
- "cmd/*"
- "admin"
- "client"
Expand Down Expand Up @@ -349,7 +350,7 @@ EOF
disabled="-D=$DISABLED_GOLANGCI_LINTERS"
fi

./bin/golangci-lint $GOLANGCI_FLAGS run "$enabled" "$disabled" --verbose --go="$GO_VERSION" --skip-dirs="(admin|client)" --timeout=5m $GOLANGCI_TAGS
./bin/golangci-lint $GOLANGCI_FLAGS run "$enabled" "$disabled" --verbose --go="$GO_VERSION" --exclude-dirs="(admin|client)" --timeout=5m $GOLANGCI_TAGS
echo "FINISHED golangci-lint checks"

# Cleanup
Expand Down

0 comments on commit 2c5ac41

Please sign in to comment.