Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated skip-dirs flag and update contributing.md #295

Merged
merged 2 commits into from
May 10, 2024
Merged

Replace deprecated skip-dirs flag and update contributing.md #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d3eb5
replace TravisCI with GitHub Actions in contributing.md
m-orion-cook May 10, 2024
89883cf
replace deprectated skip-dirs with exclude-dirs in lint-project.sh
m-orion-cook May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ A good quality PR will have the following characteristics:

A good PR should be able to flow through a peer review system easily and quickly.

Our Build pipeline utilizes [Travis-CI](https://travis-ci.org/moov-io/ach) to enforce many tools that you should add to your editor before issuing a pull request.
Our Build pipeline utilizes [GitHub Actions](https://github.com/moov-io/infra/actions) to enforce many tools that you should add to your editor before issuing a pull request.
5 changes: 3 additions & 2 deletions go/lint-project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@ run:
timeout: 5m
tests: false
go: "$GO_VERSION"
skip-dirs:
issues:
exclude-dirs:
- "cmd/*"
- "admin"
- "client"
Expand Down Expand Up @@ -349,7 +350,7 @@ EOF
disabled="-D=$DISABLED_GOLANGCI_LINTERS"
fi

./bin/golangci-lint $GOLANGCI_FLAGS run "$enabled" "$disabled" --verbose --go="$GO_VERSION" --skip-dirs="(admin|client)" --timeout=5m $GOLANGCI_TAGS
./bin/golangci-lint $GOLANGCI_FLAGS run "$enabled" "$disabled" --verbose --go="$GO_VERSION" --exclude-dirs="(admin|client)" --timeout=5m $GOLANGCI_TAGS
echo "FINISHED golangci-lint checks"

# Cleanup
Expand Down
Loading