Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make license-ls compatible with npm 7.x #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sch0rsch
Copy link

This fixes issue #20

  • do not pass --csv-option to npm list and make license-ls compatible with npm 7.x
  • handle errors and stop the spinner so that the program terminates
  • small refactorings

adding tests to verify that license-ls runs correctly
and that npmList(...) calls handle complex options
Catch errors, log them and stop the spinner so the processr
terminates when failures happen
@thefurdui
Copy link

@morficus, please, review

@dotcs
Copy link

dotcs commented Apr 25, 2022

@sch0rsch I found that changes in this PR not replicate the previous behavior. It only lists direct dependencies - even without configuring --depth 0. See the docs for npm list which since v7 state that

This command will print to stdout all the versions of packages that are installed, as well as their dependencies when --all is specified, in a tree structure.

So I think an additional --all is required. I've implemented this in a bugfix branch in my own fork.

Additional note for those that wait on @morficus merging this PR: In the meantime, you can use npx capabilities to run from a GitHub repository branch directly. To run the changes in this PR run npx --yes sch0rsch/license-ls#make-compatible-with-npm-7 or use npx --yes dotcs/license-ls#npm-7+ which includes the fix mentioned above.

@robross0606
Copy link

Two years and this still hasn't been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants