Skip to content

Commit

Permalink
feat(fdc3): Implement RaiseIntent, AddIntentListener, FindIntent and …
Browse files Browse the repository at this point in the history
…FindIntentsByContext (#383)

* feat(fdc3): Implement RaiseIntent, AddIntentListener, FindIntent and FindIntentsByContext

* feat(fdc3): Corrections based on PR feedback, bugfixes, more tests

* feat(fdc3): Added ModuleLoader to EndToEndTests, hardcoded testcases for EndToEnd tests, restructured methods, internal sealed contracts, added Fdc3StartupParameters, messageIds to messages, fixed locking

* feat(fdc3) - Hard coded expected test results for unit tests, mocking ModuleLoader, using AppDirectory, validating the config in ComposeUIDesktopAgent.ts's ctor, fixed Fdc3StartupAction to insert Fdc3StartupProperties always

* feat(fdc3): Fix package-lock.json file after merge conflict

* fix(fdc3) - Separated communication and Fdc3DesktopAgentBridge, removed extra locks

* feat(fdc3) - Adjust PR feedback, corrected comments, typos, docs, separated methods

* feat(fdc3): Fix naming conventions, removed comments, fixed test

* fix(fdc3) - Removed AppDirectorySample.cs file, added sample appdirectory json file under examples, corrected boolean argument for ts files

* Removed unnecessary partial keywords

* Moved running module shutdown logic to DisposeAsync

* Removed static resources from Fdc3DesktopAgentTests

* Removed static state from Fdc3DesktopAgentMessageRouterService.Tests

* fix(fdc3): Renamed classes, TimeSpan instead of int, fixed sentences, removed boilerplate code, renamed methods, other fixes based on the feedback (used suggested changes, logging error instead of warnings, JsonSerializerOptions, fixed tests for that)

* fix(fdc3): Moved business logic leftover to the DesktopAgent from the MessageRouterService

---------

Co-authored-by: Róbert Zöldi-Kovács <[email protected]>
  • Loading branch information
lilla28 and ZKRobi authored Jan 16, 2024
1 parent 6ae9638 commit cb5188c
Show file tree
Hide file tree
Showing 115 changed files with 8,915 additions and 3,192 deletions.
70 changes: 70 additions & 0 deletions examples/fdc3-appdirectory/apps-with-intents.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
{
"applications": [
{
"appId": "Morgan Stanley",
"name": "Morgan Stanley",
"type": "web",
"details": {
"url": "http://www.morganstanley.com"
},
"interop": {
"intents": {}
}
},
{
"appId": "Microsoft",
"name": "Microsoft",
"type": "web",
"details": {
"url": "http://www.microsoft.com"
},
"interop": {
"intents": {
"listensFor": {
"startMicrosoft": {
"name": "startMicrosoft",
"displayName": "StartMicrosoft",
"contexts": [
"fdc3.nothing"
]
}
},
"raises": {}
}
}
},
{
"appId": "Google",
"name": "Google",
"type": "web",
"details": {
"url": "http://www.google.com"
},
"interop": {
"intents": {
"listensFor": {
"viewGoogle": {
"name": "viewGoogle",
"displayName": "ViewGoogle",
"contexts": [
"fdc3.testContext"
]
}
},
"raises": {}
}
}
},
{
"appId": "FINOS FDC3 Workbench",
"name": "FINOS FDC3 Workbench",
"type": "web",
"details": {
"url": "https://fdc3.finos.org/toolbox/fdc3-workbench/"
},
"interop": {
"intents": {}
}
}
]
}
Loading

0 comments on commit cb5188c

Please sign in to comment.