Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the stack as noexec in asm files #174

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

octurion
Copy link
Contributor

@octurion octurion commented Jul 2, 2024

A missing .note.GNU-stack section implicitly marks the stack as PROT_EXEC:

warning: ProbeCtl.o: missing .note.GNU-stack section implies executable stack
NOTE: This behaviour is deprecated and will be removed in a future version of the linker

AFAICT, Xpedite doesn't rely on an executable stack, so we can explicitly mark it as noexec.

EDIT: Covered by dco/alexandros-tasos.md

@Mani-D
Copy link
Collaborator

Mani-D commented Jul 2, 2024

@octurion Thank you for spotting the issue and we are glad to receive the PR.
Since this is the first time you are contributing, we need the PR to include a DCO document.
Can you please take a look at the instructions here?

Please let me know if you need any details / clarification.

Regards
Mani

@octurion
Copy link
Contributor Author

octurion commented Jul 3, 2024

Please let me know if you need any details / clarification.

Just a quick question: Given that the DCO document is going to be public, is it okay if I e.g. obfuscate my email address in my DCO so that it can't be easily scraped?

@Mani-D
Copy link
Collaborator

Mani-D commented Jul 3, 2024

Please let me know if you need any details / clarification.

Just a quick question: Given that the DCO document is going to be public, is it okay if I e.g. obfuscate my email address in my DCO so that it can't be easily scraped?

yes, of course.

@octurion
Copy link
Contributor Author

octurion commented Jul 4, 2024

DCO added 👍

@Mani-D Mani-D merged commit 5b1859b into morganstanley:main Jul 4, 2024
2 checks passed
@Mani-D
Copy link
Collaborator

Mani-D commented Jul 4, 2024

DCO added 👍

Excellent. Thank you !

@octurion octurion deleted the mark-stack-as-noexec branch July 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants