Preliminary Scopes Implementation #102
Conversation
| */ | ||
| public createScope(scopeName: string): IMessageBroker<T> { | ||
| const scope = rootInjector.createScope(scopeName); | ||
| scope.registerInstance(MessageBroker, new MessageBroker<T>(new RSVPMediator(), this)); |
There was a problem hiding this comment.
So we will have a scoped RSVPMediator too. We ok with that? What does that mean? Is it still global in nature under the covers?
|
I think we need some additional docs for this change which details about how messages propagate up and down scopes. |
|
What are we doing about scope disposal. I think it needs to be part of this process. |
That's a good point, there should be a mechanism for disposing of a scope similar to what exists for channels. This also made me realise another point - given that messages on a channel trickle down to the same channel in child scopes, the existing disposal logic should dispose of the same channel in the children. |
An initial attempt at implementing scopes to get some ideas and discussions going. I'm wondering if there is a better way to do the instantiation using Needle...