Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid hash algorithm name #486

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

karan6181
Copy link
Collaborator

@karan6181 karan6181 commented Oct 25, 2023

Description of changes:

  • Added a check for invalid hash algorithm name.
  • Added the test case for the same.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@karan6181 karan6181 requested review from knighton, snarayan21 and XiaohanZhangCMU and removed request for knighton October 25, 2023 17:02
@karan6181 karan6181 changed the title Validate list of hashing algorithms Check for invalid hash algorithm name Oct 26, 2023
streaming/base/stream.py Outdated Show resolved Hide resolved
streaming/base/stream.py Outdated Show resolved Hide resolved
@karan6181 karan6181 merged commit 8525232 into mosaicml:main Oct 26, 2023
@karan6181 karan6181 deleted the hash_list branch October 26, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants