Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tooling, converted to dotnet core/netstandard #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kdaveid
Copy link

@kdaveid kdaveid commented Feb 4, 2020

Hi there!
Thanks for this awesome library

We're evaluating to use your library for a project and in this step we:

  • updated to new tooling;
  • converted library to dotnet standard;
  • updated windows forms to 4.6.1
  • removed packages

All unit tests are green, everything works as expected.

@lellis1936
Copy link

kdaveid, the base project has some bugs which, if not corrected, can result in unrecoverable shares being produced. I have a pull request which corrects these bugs but the original author has not applied it. Unfortunately the changes were fairly involved. In any event in any serious use case you need to consider this prospect. If you have any questions I'll try to answer them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants