fix data race

mosn · Sep 13, 2024 · 61e3b05 · 61e3b05
1 parent c67b062
commit 61e3b05
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/controller/registries/nacos/config.go b/controller/registries/nacos/config.go
@@ -289,15 +289,15 @@ func (reg *Nacos) Reload(c registrytype.RegistryConfig) error {
 
 	reg.version = config.Version
 
+	reg.lock.Lock()
+	defer reg.lock.Unlock()
+
 	cli, err := reg.createClient(config)
 	if err != nil {
 		return err
 	}
 	reg.client = cli
 
-	reg.lock.Lock()
-	defer reg.lock.Unlock()
-
 	fetchedServices, err := reg.client.FetchAllServices()
 	if err != nil {
 		return fmt.Errorf("fetch all services error: %v", err)