feat: add disable_x_envoy_ratelimited_header option

mosn · Jan 11, 2025 · c57842f · c57842f
1 parent 8c55999
commit c57842f
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 8 deletions.
diff --git a/plugins/plugins/limitcountredis/config_test.go b/plugins/plugins/limitcountredis/config_test.go
@@ -66,6 +66,10 @@ func TestConfig(t *testing.T) {
 			name:  "pass",
 			input: `{"address":"127.0.0.1:6479", "rules":[{"count":1,"timeWindow":"1s"}], "prefix":"test"}`,
 		},
+		{
+			name:  "disable x-envoy-ratelimited header",
+			input: `{"address":"127.0.0.1:6479", "rules":[{"count":1,"timeWindow":"1s"}], "prefix":"test", "disable_x_envoy_ratelimited_header": true}`,
+		},
 	}
 
 	for _, tt := range tests {

diff --git a/plugins/plugins/limitcountredis/filter.go b/plugins/plugins/limitcountredis/filter.go
@@ -161,7 +161,7 @@ func (f *filter) DecodeHeaders(headers api.RequestHeaderMap, endStream bool) api
 		remain := ress[2*i].(int64)
 		if remain < 0 {
 			hdr := http.Header{}
-			if config.EnableLimitQuotaHeaders {
+			if !config.DisableXEnvoyRatelimitedHeader {
 				hdr.Set("x-envoy-ratelimited", "true")
 			}
 			status := 429

diff --git a/types/plugins/limitcountredis/config.pb.go b/types/plugins/limitcountredis/config.pb.go
diff --git a/types/plugins/limitcountredis/config.pb.validate.go b/types/plugins/limitcountredis/config.pb.validate.go
diff --git a/types/plugins/limitcountredis/config.proto b/types/plugins/limitcountredis/config.proto
@@ -58,4 +58,6 @@ message Config {
 
   // There is no special reason to limit the length <=128, just to avoid too long string
   string prefix = 12 [(validate.rules).string = {min_len: 1, max_len: 128}];
+
+  bool disable_x_envoy_ratelimited_header = 13;
 }