Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting listener access log via listenerPatch plugin #701

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

spacewander
Copy link
Member

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (db65556) to head (a223348).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
types/plugins/listenerpatch/config.go 79.16% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #701      +/-   ##
==========================================
+ Coverage   88.14%   88.47%   +0.32%     
==========================================
  Files         119      121       +2     
  Lines        5837     5995     +158     
==========================================
+ Hits         5145     5304     +159     
+ Misses        500      494       -6     
- Partials      192      197       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2024
@spacewander spacewander marked this pull request as ready for review August 28, 2024 02:50
Signed-off-by: spacewander <[email protected]>
@spacewander spacewander merged commit 7b103a2 into main Aug 29, 2024
17 checks passed
@spacewander spacewander deleted the 828 branch August 29, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant