feat: proto of sentinel plugin #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
- Coverage 88.29% 88.07% -0.22%
==========================================
Files 128 128
Lines 6433 6433
==========================================
- Hits 5680 5666 -14
- Misses 538 547 +9
- Partials 215 220 +5 ☔ View full report in Codecov by Sentry. |
spacewander
reviewed
Sep 22, 2024
types/plugins/sentinel/config.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) Type() plugins.PluginType { | ||
| return plugins.TypeTransform |
There was a problem hiding this comment.
Better to use Traffic:
Line 27 in 81bc6af
There was a problem hiding this comment.
My carelessness. Done
spacewander
approved these changes
Sep 22, 2024
|
Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #725
Define the sentinel plugin configuration structure