Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move istio out of repo #772

Merged
merged 2 commits into from
Oct 23, 2024
Merged

build: move istio out of repo #772

merged 2 commits into from
Oct 23, 2024

Conversation

spacewander
Copy link
Member

Fix #768

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.58%. Comparing base (715dd41) to head (b47198b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   87.70%   87.58%   -0.13%     
==========================================
  Files         136      136              
  Lines        8157     8157              
==========================================
- Hits         7154     7144      -10     
- Misses        782      789       +7     
- Partials      221      224       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spacewander spacewander marked this pull request as ready for review October 17, 2024 09:54
Copy link

👋 Hi, I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@github-actions github-actions bot removed the conflict label Oct 21, 2024
@spacewander spacewander merged commit f1f3d87 into main Oct 23, 2024
18 checks passed
@spacewander spacewander deleted the 10171 branch October 23, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the default download path of istio from external/istio to the outside of htnn
1 participant