Skip to content

Commit

Permalink
Merge pull request #30 from movableink/dschulze/sc-104807/release-pro…
Browse files Browse the repository at this point in the history
…cess

Use @vercel/ncc to compile the action [sc-104807]
  • Loading branch information
duncaan authored Jul 30, 2024
2 parents 634a1b7 + 28ba85e commit c52accd
Show file tree
Hide file tree
Showing 6 changed files with 31,225 additions and 9 deletions.
29 changes: 26 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,39 @@ jobs:
- uses: movableink/pr-clubhouse-lint-action@release
```
On self-hosted runners, the following is required:
```yaml
name: Shortcut
on:
pull_request:
types: [opened, edited, reopened, synchronize]

jobs:
sc_lint_pr:
name: Shortcut
runs-on: mi-gha-runner-generic
permissions:
actions: write
pull-requests: read
contents: read
steps:
- uses: movableink/pr-clubhouse-lint-action@dschulze/sc-104807/release-process
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
```
## Releasing
This action needs `node_modules` vendored, but we don't want to do so normally. To release a new version:

* Remove `node_modules`
* Check out the `release` branch
* Check out the `v1` branch
* Run `git merge master`
* Run `npm install --production` (to ensure dev dependencies don't get installed)
* Run `npm install`
* Run `npm run build`
* Commit the result, if any changes
* Push the `release` branch to Github
* Merge PR to `v1` branch

## Testing

Expand Down
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Checks pull requests to ensure they have Shortcut links
author: Movable Ink
runs:
using: "node20"
main: "./index.js"
main: "dist/index.js"
branding:
icon: clipboard
color: purple
Loading

0 comments on commit c52accd

Please sign in to comment.