Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make planning pipeline respect the allowed_planning_time #2692

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+70 −4
Open

Make planning pipeline respect the allowed_planning_time #2692

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3930be6
Make planning pipeline respect the allowed_planning_time
TomCC7 Feb 18, 2024
e37e314
feat: timeout check set error_code instead of throw
TomCC7 Feb 28, 2024
69b6de8
feat: evenly distribute the planning time among remaining planners
TomCC7 Feb 28, 2024
06377f7
test: add timeout handling test for planningpipeline
TomCC7 Feb 28, 2024
167fb5e
chore, fix: formatting and minor fixes for planning pipeline timeout
TomCC7 Mar 6, 2024
99bf09c
fix spelling
TomCC7 Mar 6, 2024
cffe188
feat: allowing extra 10ms for response adapter
TomCC7 Mar 28, 2024
af3e30e
Merge branch 'main' into main
sjahr Apr 24, 2024
f903bd0
Merge branch 'main' into main
sjahr Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion moveit_ros/planning/planning_pipeline/test/planning_pipeline_tests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ TEST_F(TestPlanningPipeline, NoPlannerPluginConfigured)

TEST_F(TestPlanningPipeline, TestTimeout)
TomCC7 marked this conversation as resolved.
Show resolved Hide resolved
{
// construct pipline
// construct pipeline
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know that checker also checks for spelling lol

EXPECT_NO_THROW(pipeline_ptr_ = std::make_shared<planning_pipeline::PlanningPipeline>(
robot_model_, node_, "", PLANNER_PLUGINS, REQUEST_ADAPTERS, RESPONSE_ADAPTERS));

Expand Down
Loading