Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cache-source deprecation #3006

Closed
wants to merge 2 commits into from
Closed

fix cache-source deprecation #3006

wants to merge 2 commits into from

Conversation

mosfet80
Copy link
Contributor

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@mosfet80 mosfet80 changed the title Update tutorial_docker.yaml fix cache-source deprecation Sep 19, 2024
"var-cache-apt": "/var/cache/apt",
"var-lib-apt": "/var/lib/apt"
}
skip-extraction: ${{ steps.cache.outputs.cache-hit }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache id doesn't exist yet.

Comment on lines +58 to +59
"var-cache-apt": "/var/cache/apt",
"var-lib-apt": "/var/lib/apt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't cache apt stuff, but the ccache:

RUN --mount=type=cache,target=/root/.ccache/,sharing=locked \

@sjahr
Copy link
Contributor

sjahr commented Oct 11, 2024

Closing this due to inactivity, feel free to re-open, when the issue is addressed

@sjahr sjahr closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants