-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework collision models for hand #95
Closed
rhaschke
wants to merge
25
commits into
moveit:noetic-devel
from
rhaschke:rework-coarse-hand-collisions
Closed
Rework collision models for hand #95
rhaschke
wants to merge
25
commits into
moveit:noetic-devel
from
rhaschke:rework-coarse-hand-collisions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done since the `moveit_setup_assistant` currently doesn't propagate `xacro` arguments you supply to the `urdf.xacro` file (see [this issue](moveit/moveit#1691)). We need to manually add a way to enable or disable the gripper. This can be done by creating a `panda.srdf.xacro` file.
This argument is needed for the [quickstart_in_rviz_tutorial](https://ros-planning.github.io/moveit_tutorials/doc/quickstart_in_rviz/quickstart_in_rviz_tutorial.html).
As Franka changed the collision geometries from meshes to coarse shapes (matching the collision model of the internal controller) we now observe various self-collisions in some default poses. This commit disables collision checks between link8 and links 5+6.
This file can be used to control a real Panda using MoveIt.
This commit adds the files needed for running the trajopt planner example that is found in the [moveit_tutorials](https://ros-planning.github.io/moveit_tutorials/doc/trajopt_planner/trajopt_planner_tutorial.html). This planner is not included into `move_group.launch` by default but can be invoked via the `pipeline` argument. This was done since it is not yet officially released (see moveit/moveit#1467).
* Add stomp planner This commit adds all the scripts needed to run the STOMP planner example in the [stomp_planner_tutorial](https://ros-planning.github.io/moveit_tutorials/doc/stomp_planner/stomp_planner_tutorial.html).
Keep manually adjusted joint limits from the original Melodic branch.
Adds files needed to run the [lerp_planning_example](https://ros-planning.github.io/moveit_tutorials/doc/creating_moveit_plugins/plugin_tutorial.html)
* Add demo_chomp.launch * Restore original 'chomp_planning.yaml' config * Add CHOMP post-processing example, using OMPL+CHOMP
This commit removes the kinematics from the `run_benchmark_trajopt.launch` launch file since they are already handled in `planning_context.launch`.
This commit adds demo_gazebo.launch using the gazebo simulation of the franka_gazebo package Additionally, the virtual_joint is removed from the move group definition.
We can define all available controllers in a single file, even if we don't actually use those controllers. Thus, we don't need an extra set of files for panda_gripper.
Fixes the following error: [FATAL] ros.moveit_ros_planning.trajectory_execution_manager: Exception while loading controller manager 'panda': According to the loaded plugin descriptions the class panda with base class type moveit_controller_manager::MoveItControllerManager does not exist.
- headless = !gazebo_gui - Remove arg load_robot_description: We always load the robot description via franka_gazebo to enable Gazebo features in URDF - Use <group> tag to declare namespace once
- Use factors of pi - Fix joint limit violation for "extended" pose
Collision between them is handled by joint limits already
... utilizing a new feature of MoveIt / SRDF Now, it's possible to disable collision for a specific collision name by default. The definition of specific collision pairs will override this default. This allows disabling collision for the coarse hand geometries and enabling it for selected pairs of links only (for self-collision checking). On the other hand, the detailed hand collision geometries are enabled by default, but selectively disabled for self-collision checking for all arm links.
This was referenced Nov 2, 2021
rhaschke
force-pushed
the
noetic-devel
branch
from
November 8, 2021 08:38
c2eeb1f
to
10c91d7
Compare
Superseded by new (force-pushed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes a new feature of MoveIt / SRDF, namely moveit/moveit#2938 and moveit/srdfdom#97.
Now, it's possible to disable collision for a specific collision name by default.
The definition of specific collision pairs will override this default.
This allows disabling collision for the coarse hand geometries and enabling it for selected pairs of links only (for self-collision checking).
On the other hand, the detailed hand collision geometries are enabled by default, but selectively disabled for self-collision checking for all arm links.
This goes in line with:
Rework hand collision frankaemika/franka_ros#189Provide detailed and coarse collision models frankaemika/franka_ros#199
defining detailed (panda_hand) and coarse (panda_hand_coarse) collision models
allowing collision checking to be disabled by default for specific links
extending the syntax of SRDF to specify these defaults (and exceptions)