Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework collision models for hand #95

Closed

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Nov 2, 2021

This PR utilizes a new feature of MoveIt / SRDF, namely moveit/moveit#2938 and moveit/srdfdom#97.

Now, it's possible to disable collision for a specific collision name by default.
The definition of specific collision pairs will override this default.

This allows disabling collision for the coarse hand geometries and enabling it for selected pairs of links only (for self-collision checking).

On the other hand, the detailed hand collision geometries are enabled by default, but selectively disabled for self-collision checking for all arm links.

This goes in line with:

rickstaa and others added 25 commits September 28, 2021 19:48
This was done since the `moveit_setup_assistant` currently doesn't propagate `xacro` arguments you supply to the `urdf.xacro` file (see [this issue](moveit/moveit#1691)). We need to manually add a way to enable or disable the gripper. This can be done by creating a `panda.srdf.xacro` file.
As Franka changed the collision geometries from meshes to coarse shapes
(matching the collision model of the internal controller) we now observe various self-collisions
in some default poses. This commit disables collision checks between link8 and links 5+6.
This file can be used to control a real Panda using MoveIt.
This commit adds the files needed for running the trajopt planner example that is found in the
[moveit_tutorials](https://ros-planning.github.io/moveit_tutorials/doc/trajopt_planner/trajopt_planner_tutorial.html).
This planner is not included into `move_group.launch` by default but can be invoked via the `pipeline` argument.
This was done since it is not yet officially released (see moveit/moveit#1467).
* Add stomp planner

This commit adds all the scripts needed to run the STOMP planner example in the
[stomp_planner_tutorial](https://ros-planning.github.io/moveit_tutorials/doc/stomp_planner/stomp_planner_tutorial.html).
Keep manually adjusted joint limits from the original Melodic branch.
* Add demo_chomp.launch
* Restore original 'chomp_planning.yaml' config
* Add CHOMP post-processing example, using OMPL+CHOMP
This commit removes the kinematics from the `run_benchmark_trajopt.launch`
launch file since they are already handled in `planning_context.launch`.
This commit adds demo_gazebo.launch using the gazebo simulation of the franka_gazebo package
Additionally, the virtual_joint is removed from the move group definition.
We can define all available controllers in a single file,
even if we don't actually use those controllers.
Thus, we don't need an extra set of files for panda_gripper.
Fixes the following error:
[FATAL] ros.moveit_ros_planning.trajectory_execution_manager:
  Exception while loading controller manager 'panda':
  According to the loaded plugin descriptions the class panda
  with base class type moveit_controller_manager::MoveItControllerManager does not exist.
- headless = !gazebo_gui
- Remove arg load_robot_description:
  We always load the robot description via franka_gazebo to enable Gazebo features in URDF
- Use <group> tag to declare namespace once
- Use factors of pi
- Fix joint limit violation for "extended" pose
Collision between them is handled by joint limits already
... utilizing a new feature of MoveIt / SRDF
Now, it's possible to disable collision for a specific collision name by default.
The definition of specific collision pairs will override this default.

This allows disabling collision for the coarse hand geometries
and enabling it for selected pairs of links only (for self-collision checking).

On the other hand, the detailed hand collision geometries are enabled by default,
but selectively disabled for self-collision checking for all arm links.
@rhaschke
Copy link
Contributor Author

rhaschke commented Nov 8, 2021

Superseded by new (force-pushed) noetic-devel branch.

@rhaschke rhaschke deleted the rework-coarse-hand-collisions branch September 1, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants