Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install headers into include/srdfdom/srdfdom #132

Merged
merged 3 commits into from
Oct 13, 2024
Merged

Conversation

rhaschke
Copy link
Contributor

... to make overlays work as suggested in moveit/moveit2#3003 (comment)

@rhaschke
Copy link
Contributor Author

Format failure is due to pre-commit/action#213

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.34%. Comparing base (ad17b8d) to head (ceafeaf).
Report is 10 commits behind head on ros2.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             ros2     #132      +/-   ##
==========================================
- Coverage   67.09%   60.34%   -6.74%     
==========================================
  Files           3        4       +1     
  Lines         641      658      +17     
  Branches        0       87      +87     
==========================================
- Hits          430      397      -33     
- Misses        211      213       +2     
- Partials        0       48      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sea-bass
Copy link

sea-bass commented Oct 13, 2024

How do ROS releases work in terms of amending the 2.0.5 release that is queued for sync? Does this change make it 2.0.6, or can we do a 2.0.5-2 type thing since the release is not yet available?

@rhaschke
Copy link
Contributor Author

We need to release as 2.0.6.
The version suffix -2 is automatically added by the buildfarm for a new build of the same release.

@rhaschke
Copy link
Contributor Author

I will merge this and handle a new release as soon as https://github.com/rhaschke/moveit2/actions/runs/11315638584/job/31467055018 succeeds.

@rhaschke rhaschke merged commit ceafeaf into moveit:ros2 Oct 13, 2024
11 checks passed
@rhaschke
Copy link
Contributor Author

Release triggered: ros/rosdistro#43168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants