-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install headers into include/srdfdom/srdfdom #132
Conversation
... to make overlays work
Format failure is due to pre-commit/action#213 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## ros2 #132 +/- ##
==========================================
- Coverage 67.09% 60.34% -6.74%
==========================================
Files 3 4 +1
Lines 641 658 +17
Branches 0 87 +87
==========================================
- Hits 430 397 -33
- Misses 211 213 +2
- Partials 0 48 +48 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
How do ROS releases work in terms of amending the 2.0.5 release that is queued for sync? Does this change make it 2.0.6, or can we do a 2.0.5-2 type thing since the release is not yet available? |
We need to release as 2.0.6. |
I will merge this and handle a new release as soon as https://github.com/rhaschke/moveit2/actions/runs/11315638584/job/31467055018 succeeds. |
Release triggered: ros/rosdistro#43168 |
... to make overlays work as suggested in moveit/moveit2#3003 (comment)