ENG-302: Remove and feature-gate parallel block execution #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to drop the rayon dependency from the aptos-block-executor crate.
mzabaluev
force-pushed
the
mikhail/feature-gate-parallelism
branch
from
6aa5f7e
to
1434fc3
Compare
Put sharded block execution code and its associated rayon dependency behind the "sharded" feature. To avoid conditionally defined methods in the VMExecutor trait, factor out the SerialVMExecutor trait that is a supertrait of VMExecutor, gate VMExecutor with the "sharded" feature, and move the non-sharded methods to the unconditional supertrait.
|
The error I'm getting in unit tests after replacing parallel execution with sequential:
|
mzabaluev
force-pushed
the
mikhail/feature-gate-parallelism
branch
from
1434fc3
to
c11a9a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cut out or conditionally disable parallel block execution from
aptos-vmandaptos-block-executorcrates, removing therayondependency for the RISC0 build. Conditional compilation with feature-gating should be used when the APIs are also used in the host build.Test Plan