Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major fixes #455

Merged
merged 14 commits into from
May 31, 2024
Merged

major fixes #455

merged 14 commits into from
May 31, 2024

Conversation

dividehex
Copy link
Contributor

@dividehex dividehex commented Dec 7, 2023 •
edited
Loading

This is a collection of major changes to the auth0 rules in order to fix various issues.

@dividehex
Copy link
Contributor Author

dividehex commented Dec 7, 2023 •
edited
Loading

This is still a WIP but I would like to start getting feedback on this work.

floatingatoll
floatingatoll reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@floatingatoll floatingatoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a code comments skim for now, but this generally seems reasonable. I'll review logic tomorrow.

connections/firefoxaccounts.js Outdated Show resolved Hide resolved
rules/link-users-by-email-with-metadata.js Outdated Show resolved Hide resolved
rules/link-users-by-email-with-metadata.js Outdated Show resolved Hide resolved
gcoxmoz
gcoxmoz reviewed May 29, 2024
View reviewed changes
rules/Global-Function-Declarations.js Outdated Show resolved Hide resolved
rules/force-ldap-logins-over-ldap.js Outdated Show resolved Hide resolved
gcoxmoz
gcoxmoz approved these changes May 29, 2024
View reviewed changes
Copy link

@gcoxmoz gcoxmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm a qualified reviewer on this repo, and you should take my JS reading with a lot of salt, but, I can see where you're going. Attempting an r+ but I bet it'll be squashed to just an f+

floatingatoll
floatingatoll approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@floatingatoll floatingatoll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've read through all of this and it seems familiar and/or fine. (Other reviews also welcome.)

frosemond
frosemond approved these changes May 29, 2024
View reviewed changes
Copy link

@frosemond frosemond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up work!

@dividehex
Last minute fixes and cleanup
8435755 
        * Added missing semicolons and remove unnecessary one
        * Removed publishSNSMessage function which was a legacy alert
          component and not longer used.
        * Rearranged function declaration and call to proper
          declare->call order
@dividehex
More cleanup after testing
6569b1e 
        * Fixed the auth0 API URL path
        * Changed the searchMultipleEmailCases call to a .then().catch()
          in order to properly resolve the returned promise
@dividehex
Copy link
Contributor Author

The current state of this PR has been tested up and down on the dev tenant.

@dividehex dividehex requested a review from frosemond May 30, 2024 18:33
@dividehex dividehex merged commit 5c26bb1 into mozilla-iam:master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floatingatoll floatingatoll floatingatoll approved these changes

@frosemond frosemond frosemond approved these changes

@gcoxmoz gcoxmoz gcoxmoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dividehex @floatingatoll @frosemond @gcoxmoz