Skip to content

Commit

Permalink
Reflect review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
bcolsson committed Sep 17, 2024
1 parent f83687e commit d3aac7d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
Binary file modified src/assets/images/mercurial/searchfox-path.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/assets/images/pontoon/ui/editing_space_standard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 5 additions & 3 deletions src/tools/mercurial/tracking_back_string_to_bug.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,23 @@ The results may look something like this:

![Searchfox](../../assets/images/mercurial/searchfox.png)

We can further refine results to only localization files by using `locales/en-US` in the `Path filter` field in the top right to limit search results to localization files.
You can further refine results to only localization files by using specific localization file extensions in the `Path filter` field in the top right:
* For Firefox: limit the search to `.ftl` or `.properties` files. You can find information on the file from its [CONTEXT](../pontoon/ui.md#context). Or you can use `{.ftl,.properties}` to only show files with those extensions.
* For Android: limit the search to `.xml` files.

![Searchfox](../../assets/images/mercurial/searchfox-path.png)

Clicking on the string will open the file in Searchfox and highlight the string.

## Find the bug

Searchfox shows details on the revision that each line of code was introduced to the file, represented on the left hand sign as a bar with alternating shades of gray. Hovering over the bar next to the highlighted line containing your string will show you the revision details. The first line of the revision details contains a bug reference, a number represented as a link. Clicking the link will take you to Bugzilla where you can then check things like dependencies and comments.
Searchfox shows details on the revision in which each line of code was introduced to the file, represented on the left hand sign as a bar with alternating shades of gray. Hovering over the bar next to the highlighted line containing your string will show you the revision details. The first line of the revision details contains a bug reference, a number represented as a link. Clicking the link will take you to Bugzilla where you can then check things like dependencies and comments.

![Searchfox](../../assets/images/mercurial/searchfox-revision.png)

### Examining the changeset in Mercurial

You can also access the changeset in Mercurial. To view that, click `full diff` on the third line that says `Show annoated diff or full diff`.
You can also access the changeset in Mercurial. To view that, click `full diff` on the third line that says `Show annotated diff or full diff`.

This will show the full commit message and all the changes made as part of the bug.

Expand Down
2 changes: 1 addition & 1 deletion src/tools/pontoon/ui.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ In the same area, the `REQUEST CONTEXT or REPORT ISSUE` button can be used to re

#### Context

Sometimes you may want to investigate more context about a particular string through an external resource such as a [Version Control System](glossary.md#version-control-system). The `CONTEXT` information provided underneath the source string shows the identifier, file, and project for the string - allowing you to find the string within the codebase of the project. For example, for some Mozilla projects these can be used to [track strings to bugs](../mercurial/tracking_back_string_to_bug.md).
Sometimes you may want to investigate more context about a particular string through an external resource such as a [Version Control System](glossary.md#version-control-system). The `CONTEXT` information provided underneath the source string shows the identifier, file, and project for the string allowing you to find the string within the codebase of the project. For example, for some Mozilla projects these can be used to [track strings to bugs](../mercurial/tracking_back_string_to_bug.md).

![Context](../../assets/images/pontoon/ui/context.png)

Expand Down

0 comments on commit d3aac7d

Please sign in to comment.