Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from bedrock #431

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Updates from bedrock #431

merged 2 commits into from
Sep 17, 2024

Conversation

MozmarRobot
Copy link
Collaborator

From file changes in mozilla/bedrock@cf21cf2

@MozmarRobot MozmarRobot requested a review from a team as a code owner September 13, 2024 21:05
Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@craigcook not sure who is working on this PR, but in looking at https://www-dev.allizom.org/en-US/ - the title case or capitalization of title case is inconsistent depending on where you look. In most situation, it looks like this Title case. But some are not: Firefox Blog (under Firefox Browsers). Under About us where Innovation Projects is not consistent with the rest (MoFo is an exception in this case).

The footer's title case seems to have capital initials like Footer Title Case vs. Navigation title case (or inconsistent within each menu).

navigation-refresh-mozilla-manifesto = { -brand-name-mozilla } manifesto
navigation-refresh-mozilla-foundation = { -brand-name-mozilla-foundation }
navigation-refresh-get-involved = Get involved
navigation-refresh-innovation-projects = Innovation Projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Innovation projects (lower case P) to be consistent with other list of items?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentance case is the official word going foward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People are doing a bit of everything right now. @craigcook do you want take a pass on capitalization on Monday? I can if you're busy but I know you're better with speling.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this updated soon as it's time sensitive. Anymore strings to come in the next couple of days?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgibson not sure if you can help fix this. We are pressing for time. If this is the last update before next week, let's finalize it. If there are more things to come, can we bundle them? Thank you!

Copy link
Contributor

@alexgibson alexgibson Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peiying2 I will take a look here thanks for the ping

Edit: I'm going to assume sentence case is what we should be using for all titles in the nav

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peiying2 PR here that should hopefully address things: mozilla/bedrock#15164

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Copy link
Contributor

@peiying2 peiying2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call out a few list items to use "sentence case".

Do we change Fireflx Browsers to Firefox browsers?

navigation-refresh-firefox-focus = { -brand-name-firefox-focus }
navigation-refresh-firefox-relay = { -brand-name-firefox-relay }
navigation-refresh-all-products = All products
navigation-refresh-firefox-blog = { -brand-name-firefox } Blog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be lower case B so it reads Firefox blog?

@peiying2 peiying2 merged commit 14b2313 into master Sep 17, 2024
2 checks passed
@peiying2 peiying2 deleted the update-from-bedrock-cf21cf26 branch September 17, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants