If the request store is empty, generate an empty Object response (#332)

* If the request store is empty, generate an empty Object response * Don't fail if prefs is null * Don't return null if the object doesn't contain any keys. Instead, return an empty WritableMap * Unused import
mozilla-magnet · Nov 18, 2016 · 1eb7d6e · 1eb7d6e
1 parent 9cb39c9
commit 1eb7d6e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/android/app/src/main/java/org/mozilla/magnet/api/Utils.java b/android/app/src/main/java/org/mozilla/magnet/api/Utils.java
@@ -83,10 +83,9 @@ public static WritableMap jsonToWritableMap(JSONObject jsonObject) {
             return null;
         }
 
-
         Iterator<String> iterator = jsonObject.keys();
         if (!iterator.hasNext()) {
-            return null;
+            return writableMap;
         }
 
         while (iterator.hasNext()) {
@@ -155,4 +154,4 @@ public static WritableArray jsonArrayToWritableArray(JSONArray jsonArray) {
 
         return writableArray;
     }
-}
+}
diff --git a/android/app/src/main/java/org/mozilla/magnet/magnetapi/ApiPreferences.java b/android/app/src/main/java/org/mozilla/magnet/magnetapi/ApiPreferences.java
@@ -28,7 +28,13 @@ class ApiPreferences extends Api {
      */
     @Override
     public void get(String aPath, Callback aCallback) {
-        aCallback.resolve(getCache().getJsonObject(PREFERENCES_STORE_KEY));
+        JSONObject json = getCache().getJsonObject(PREFERENCES_STORE_KEY);
+
+        if (json == null) {
+          json = new JSONObject();
+        }
+
+        aCallback.resolve(json);
     }
 
     /**

diff --git a/lib/app.js b/lib/app.js
@@ -199,7 +199,7 @@ class App extends React.Component {
     debug('inflate user flags');
     return api.get('preferences')
       .then(prefs => {
-        Object.keys(prefs ).forEach(key => {
+        Object.keys(prefs).forEach(key => {
           debug('got user flag', key, prefs[key]);
           const value = parseBoolean(prefs[key]);
           if (value == null) return;