-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deep linking (closes #331) #338
Merged
wilsonpage
merged 31 commits into
mozilla-magnet:master
from
wilsonpage:331-poi-deep-linking-android
Nov 21, 2016
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3a1c7f5
Add incoming url detection logic, mapped to openItem
wilsonpage dd6097f
Add custom protocol handling
wilsonpage b085e9e
Add missing return statements
wilsonpage 956defb
Add .postArray() method to cope with JSON array posting
wilsonpage 86b891a
Change redux architecture to fetch on demand
wilsonpage 2433cf5
Remove redundant metadata fetcher
wilsonpage 3802873
Show loading indicator when resolving item
wilsonpage 7d30fb2
Protect against navigator not being defined yet
wilsonpage cc911bc
Remove dead module
wilsonpage 5f3404d
Change to use proper async redux actions for data retrieval
wilsonpage 0875155
Fix loading spinner styling
wilsonpage f95b3f0
Listen for deep-links when app is running
wilsonpage e3ff64f
Add support for POSTing JSON arrays
wilsonpage 54e19a6
Fix incorrect props mapping
wilsonpage ba5bc4d
Yarn lock not up-to-date for some reason
wilsonpage 4b8ea0f
Remove expiring logic as needs to be moved to native scanners
wilsonpage 4a04ea0
Moved network status logic into redux store
wilsonpage 07b18be
Fix refresh logic to be based on 'nearbyItems' not 'items'
wilsonpage 5e117dd
Add missing file for network checks
wilsonpage 471894c
Remove unused callback
wilsonpage 3d823ce
Fix tests
wilsonpage ba0c461
Add native linking logic for ios
wilsonpage 14d6cc8
yarn.lock not updated
wilsonpage 4eb9199
Fix broken unit-tests
wilsonpage 9ef79f7
Rename files to match class names
wilsonpage fe35759
Use InteractionsManager to prevent render whilst animating
wilsonpage b72380f
Fix naming inconsistency
wilsonpage e8bf061
Don't change state when distance hasn't changed
wilsonpage 0f723ff
Update yarn.lock
wilsonpage b165b89
Fix broken test
wilsonpage b3d4447
Remove redundant code
wilsonpage File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
'use strict'; | ||
|
||
/** | ||
* Dependencies | ||
*/ | ||
|
||
const { searchServiceUrl } = require('../../config'); | ||
const debug = require('../debug')('get-item'); | ||
const api = require('.'); | ||
|
||
/** | ||
* Exports | ||
*/ | ||
|
||
module.exports = function(url) { | ||
return Promise.all([ | ||
fetchBeaconData(url), | ||
fetchMetadata(url), | ||
]) | ||
|
||
.then(results => { | ||
var item = results[0][0]; | ||
var metadata = results[1][0]; | ||
|
||
return { | ||
...item, | ||
metadata, | ||
}; | ||
}); | ||
}; | ||
|
||
function fetchMetadata(url) { | ||
return api.postArray('metadata', [url]); | ||
} | ||
|
||
function fetchBeaconData(url) { | ||
debug('fetch beacon data', url); | ||
const request = new Request(searchServiceUrl, { | ||
method: 'post', | ||
headers: new Headers({ 'Content-Type': 'application/json;charset=utf-8' }), | ||
body: JSON.stringify([url]), | ||
}); | ||
|
||
return fetch(request) | ||
.then(res => res.json()) | ||
.catch(() => { | ||
debug('no beacon data', url); | ||
return []; | ||
}); | ||
} |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*Update