This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Fix missing buttons in Find In Page bar #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sryze
changed the title
PARAIPAN9
approved these changes
Oct 26, 2023
|
This pull request has conflicts when rebasing. Can you please fix it @sryze? 🙏 |
1 similar comment
|
This pull request has conflicts when rebasing. Can you please fix it @sryze? 🙏 |
Move the corresponding icon assets to the DesginSystem module so that they can be found at runtime. Fixes mozilla-mobile#3699
When the user hasn't entered any text, the previous/next buttons were not made disabled, which could be a little bit misleading and was not consistent with the case where there are no search results.
sryze
force-pushed
the
find-in-page-buttons-fix
branch
2 times, most recently
from
b06d910
to
aac944d
Compare
|
Rebased |
isabelrios
added a commit
to isabelrios/firefox-ios
that referenced
this pull request
Mar 4, 2024
…ocus-ios#3894) * Fix invisible Find Previous & Find Next buttons Move the corresponding icon assets to the DesginSystem module so that they can be found at runtime. Fixes mozilla-mobile/focus-ios#3699 * Make Find Previous / Find Next buttons initially disabled When the user hasn't entered any text, the previous/next buttons were not made disabled, which could be a little bit misleading and was not consistent with the case where there are no search results. --------- Co-authored-by: isabelrios <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the corresponding icon assets to the DesginSystem module so that
they can be found at runtime.
When the user hasn't entered any text, the previous/next buttons were
not made disabled, which could be a little bit misleading and was not
consistent with the case where there are no search results.
Fixes #3699