Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Ubuntu 22.04 for moonshots #473

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

MasterWayZ
Copy link
Contributor

@MasterWayZ MasterWayZ commented Jan 20, 2023

TODO:

@MasterWayZ MasterWayZ force-pushed the relopsTODO branch 5 times, most recently from 2ebf26b to 4b95eee Compare January 24, 2023 23:35
@MasterWayZ MasterWayZ force-pushed the relopsTODO branch 5 times, most recently from 58e6f1e to e626051 Compare January 25, 2023 15:09
@MasterWayZ MasterWayZ changed the title DO NOT MERGE - Create Ubuntu 22.04 for moonshots Create Ubuntu 22.04 for moonshots Jan 25, 2023
@MasterWayZ MasterWayZ marked this pull request as ready for review January 25, 2023 16:19
@MasterWayZ
Copy link
Contributor Author

Squashed all commits together so the first commit doesn't say 'do not land'.
This is ready for review now.

.circleci/config.yml Outdated Show resolved Hide resolved
describe command('timedatectl status') do
its(:exit_status) { should eq 0 }

# TODO: check output if we're synced. For 22.04 the output has changed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerickson I have no clue how we'd fix that. Done this so at least I can see it everything else passes, and it does!

inventory.d/macmini-r8.yaml Outdated Show resolved Hide resolved
inventory.d/macmini-r8.yaml Outdated Show resolved Hide resolved
.kitchen_configs/kitchen.docker.yml Show resolved Hide resolved
@@ -30,8 +30,11 @@
it { should_not be_enabled }
end

describe service('whoopsie') do
it { should_not be_enabled }
# This check is broken on Ubuntu 22.04, even when the service is disabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is whoopsie even present/used in 2204?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but from what I can see it is a static service so you cannot disable it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerickson I manually ran systemctl disable whoopsie and it still fails on the test, so I think the test is broken or something changed that it works differently. On the raw ubuntu:jammy image whoopsie does not exist. I did see a apt install line for whoopsie in the output logs.. But I cannot find anything referencing it in the code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting it to disabled will make Puppet install it. Not intuitive, but it can't set disabled if the package isn't present.

Let's just do nothing regarding whoopsie on 2204 (ie in the 2204 block do nothing).

@aerickson
Copy link
Member

NTP solution is in my branch:

I think you only need the changes to ntp.pp and ntp_spec.rb.

@aerickson
Copy link
Member

We also need to switch to multiuser g-w and create a configuration that uses x11 vs wayland (link in description on how to do).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants