-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Ubuntu 22.04 for moonshots #473
base: master
Are you sure you want to change the base?
Conversation
2ebf26b
to
4b95eee
Compare
modules/roles_profiles/manifests/profiles/gecko_t_linux_talos_generic_worker.pp
Outdated
Show resolved
Hide resolved
58e6f1e
to
e626051
Compare
73d67e3
to
27161c3
Compare
Squashed all commits together so the first commit doesn't say 'do not land'. |
describe command('timedatectl status') do | ||
its(:exit_status) { should eq 0 } | ||
|
||
# TODO: check output if we're synced. For 22.04 the output has changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerickson I have no clue how we'd fix that. Done this so at least I can see it everything else passes, and it does!
@@ -30,8 +30,11 @@ | |||
it { should_not be_enabled } | |||
end | |||
|
|||
describe service('whoopsie') do | |||
it { should_not be_enabled } | |||
# This check is broken on Ubuntu 22.04, even when the service is disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is whoopsie even present/used in 2204?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but from what I can see it is a static service so you cannot disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aerickson I manually ran systemctl disable whoopsie
and it still fails on the test, so I think the test is broken or something changed that it works differently. On the raw ubuntu:jammy
image whoopsie does not exist. I did see a apt install
line for whoopsie in the output logs.. But I cannot find anything referencing it in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting it to disabled will make Puppet install it. Not intuitive, but it can't set disabled if the package isn't present.
Let's just do nothing regarding whoopsie on 2204 (ie in the 2204 block do nothing).
NTP solution is in my branch: I think you only need the changes to ntp.pp and ntp_spec.rb. |
We also need to switch to multiuser g-w and create a configuration that uses x11 vs wayland (link in description on how to do). |
TODO: