Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level option abstractions #215

Conversation

mitchhentges
Copy link
Contributor

Fixes #195

This also contains #213, so I wouldn't recommend reviewing until that change lands.

Improvements:

  • --service-account and --credentials are now only required if --do-not-contact-google-play isn't provided
  • push_apk and update_apk_description now accept types for track and connection, rather than mutually-exclusive primitive parameters
  • check_rollout no longer ignores --do-not-contact-google-play

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 95.136% when pulling 006189c on mitchhentges:top-level-option-abstractions into f41ad26 on mozilla-releng:master.

@mitchhentges
Copy link
Contributor Author

After some discussion ending here, we're not going to use types on the API boundary

@mitchhentges mitchhentges deleted the top-level-option-abstractions branch July 24, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge "track" and "rollout_percentage"
2 participants