Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

Bug 1598876 - Fix intermittent link test failure #5390

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gvn
Copy link
Contributor

@gvn gvn commented Nov 27, 2019

Run mach test discovery_render and confirm exit code of 0. (Try this several times.)

Copy link
Member

@Mardak Mardak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was making sure top sites gets rendered as well as the link getting rendered, so this change makes it only test the latter. If the link is getting delayed, you can wrap the querySelector with await ContentTaskUtils.waitForCondition just like what's done for topSites.

@ScottDowne
Copy link
Collaborator

ScottDowne commented Nov 28, 2019

I also wonder if we can instead of waiting and checking the text, just check for the href, and not the text content, thus it wouldn't need to be waiting for fluent. (we're not testing fluent anyway)

thoughts?

@ScottDowne
Copy link
Collaborator

ScottDowne commented Nov 30, 2019

Was thinking about this more. I think maybe ideally we have a test layout for this, so we don't have fluent strings being used here at all. (assuming that's the issue, which I'm only about 80% sure of)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants