Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Show "pending" activity in devhub for all versions and not just the latest one #15024

Open
1 task
diox opened this issue Sep 16, 2024 · 1 comment · May be fixed by mozilla/addons-server#22681
Open
1 task

[Task]: Show "pending" activity in devhub for all versions and not just the latest one #15024

diox opened this issue Sep 16, 2024 · 1 comment · May be fixed by mozilla/addons-server#22681
Assignees
@diox
Labels
repository:addons-server Issue relating to addons-server
Milestone
2024.10.03

Comments

@diox
Copy link
Member

diox commented Sep 16, 2024 •
edited by data-sync-user
Loading

Description

In devhub, in the version list page, if there is a reviewer comment or any other activity needing a reply from the developer as the last activity for a version, we show a count of such activities, but only for the latest version in each channel.

Since #1981, reviewers and developers will be able to leave comments for each other on any version, so we should extend that "pending" count feature to all versions and not just the latest on each channel, allowing the developer to easily see which one needs a reply.

Acceptance Criteria

Milestones/checkpoints
Beta Give feedback

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task
@diox diox added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend and removed needs:info repository:addons-frontend Issue relating to addons-frontend labels Sep 16, 2024
@diox diox self-assigned this Sep 16, 2024
@diox diox added this to the 2024.10.03 milestone Sep 16, 2024
This was referenced Sep 17, 2024
Closed
Open
@diox
Copy link
Member Author

diox commented Sep 19, 2024 •
edited
Loading

Easiest way to set up this scenario is to have an add-on with multiple versions in the same channel and then leave a reply on all the versions in reviewer tools.

A fancier variant: set up some versions without replies, some versions with multiple replies, some versions where the developer has replied to the reviewer, and some versions where the same reviewer reply was posted on multiple versions at the same time (#1981 allows this).

In any case the count should be shown in the version list for the add-on in devhub, and when clicking to view the replies the "unread" reviewer replies (that don't have a developer reply more recent) should be highlighted and match the count.

@diox diox mentioned this issue Sep 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diox diox

Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
2024.10.03
Development

Successfully merging a pull request may close this issue.

Show "pending" activity in devhub for all versions and not just the latest one diox/olympia
1 participant
@diox