Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewers should be able to reply to older versions in a channel for an add-on #1981

Closed
abhn opened this issue Jan 18, 2024 · 8 comments · Fixed by mozilla/addons-server#22661 or mozilla/addons-server#22674
Assignees
Milestone

Comments

@abhn
Copy link

abhn commented Jan 18, 2024

Describe the problem and steps to reproduce it:

Similar to #1980 add-on reviewers should be able to reply to any version of the add-on for a given channel, and not just the latest.

What happened?

When replying to an add-on in reviewer tools, the version isn't specify-able and the reply gets attached to the latest (approved?) version.

What did you expect to happen?

Reviewers can specify which version they'd like to reply to and the reply gets posted to that version of the add-on for the developer to see.

As some context on this, for unlisted add-ons, the latest approved version might not be the version that's being reviewed, and to be able to specify the version when sending a reply can help reduce the need to specify the version manually in the review message itself.

┆Issue is synchronized with this Jira Task

@lucifer1708

This comment was marked as outdated.

@diox

This comment was marked as outdated.

@KevinMind
Copy link
Contributor

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
@KevinMind KevinMind added migration:2024 repository:addons-server Issue relating to addons-server labels May 3, 2024
@diox
Copy link
Member

diox commented Aug 29, 2024

Note that developers also need to be able to reply in the same fashion. There is a potential UX issue here, in devhub it could be a little confusing for developers if the replies are attached to an older version on a different page, but we can live with that edge case. They should be able to reply by email normally.

@diox
Copy link
Member

diox commented Sep 16, 2024

Note: per request from Operations during our standup when we discussed this feature, reviewers will explicitly need to select a version when replying now (like other actions which let you select a version). Typically it should be the last one.

In addition, they can select multiple versions to reply to, and this will generate a single activity log, but it will generate multiple emails.

@ioanarusiczki
Copy link

ioanarusiczki commented Sep 17, 2024

From reviewers pages it should be fine. When developers reply to reviewers, versions are flagged for human review and get a due date.

On developers side:

  • when a reviewer is sending a reply on an older version there's no indication of this on versions page. There's a review history pending count which I saw as being present always for the latest version submitted in the channel.
    The same applies when selecting multiple versions and sending a reviewer reply, for example I've selected version 2.0 and 4.0 and sent a reviewer reply, version 4.0 gets the pending count but version 2.0 won't display that. However, emails are sent individually for each version and the reply is available for the older version too when clicking the review history.

review history

  • when sending developer replies from email for older versions there's an email sent to use https://addons-dev.allizom.org/ for leaving a reply. It's working to send a developer reply from email only for the latest version in the channel.

cannot reply try dev hub

@diox
Copy link
Member

diox commented Sep 17, 2024

So, your first point will be covered by #15024 but the second one is something I forgot to fix.

@ioanarusiczki
Copy link

I tested on -dev with extensions and today on -stage with a theme, lang pack and dictionary. Email developer replies on older versions are now working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment