-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewers should be able to reply to older versions in a channel for an add-on #1981
Reviewers should be able to reply to older versions in a channel for an add-on #1981
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Old Jira Ticket: https://mozilla-hub.atlassian.net/browse/ADDSRV-663 |
Note that developers also need to be able to reply in the same fashion. There is a potential UX issue here, in devhub it could be a little confusing for developers if the replies are attached to an older version on a different page, but we can live with that edge case. They should be able to reply by email normally. |
Note: per request from Operations during our standup when we discussed this feature, reviewers will explicitly need to select a version when replying now (like other actions which let you select a version). Typically it should be the last one. In addition, they can select multiple versions to reply to, and this will generate a single activity log, but it will generate multiple emails. |
From reviewers pages it should be fine. When developers reply to reviewers, versions are flagged for human review and get a due date. On developers side:
|
So, your first point will be covered by #15024 but the second one is something I forgot to fix. |
I tested on -dev with extensions and today on -stage with a theme, lang pack and dictionary. Email developer replies on older versions are now working 👍 |
Describe the problem and steps to reproduce it:
Similar to #1980 add-on reviewers should be able to reply to any version of the add-on for a given channel, and not just the latest.
What happened?
When replying to an add-on in reviewer tools, the version isn't specify-able and the reply gets attached to the latest (approved?) version.
What did you expect to happen?
Reviewers can specify which version they'd like to reply to and the reply gets posted to that version of the add-on for the developer to see.
As some context on this, for unlisted add-ons, the latest approved version might not be the version that's being reviewed, and to be able to specify the version when sending a reply can help reduce the need to specify the version manually in the review message itself.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: