Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Implement soft-blocking backend #15012

Closed
1 task
diox opened this issue Sep 11, 2024 · 2 comments · Fixed by mozilla/addons-server#22690
Closed
1 task

[Task]: Implement soft-blocking backend #15012

diox opened this issue Sep 11, 2024 · 2 comments · Fixed by mozilla/addons-server#22690
Assignees
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Milestone

Comments

@diox
Copy link
Member

diox commented Sep 11, 2024

Description

Part of https://docs.google.com/document/d/1RgY1N5MCNQAiKM3EK0bgvw7CZ8TolR81dF2QCNzTM2s/edit

We want to add the ability for versions to be soft-blocked.

Minimal changes to the admin should be included to make it possible to test this.

In follow-up tickets we'll add more admin functionality and generate a separate set of bloomfilter and stashes for soft-blocked versions - for now, this is about making it possible to add a soft-block internally without breaking anything.

Note that while in practice this is unlikely to come up very often, for a given Block we might end up with versions that are hard-blocked and versions that are soft-blocked : we are going to add the information of whether something is soft or hard-blocked on the BlockVersion itself.

Acceptance Criteria

Milestones/checkpoints

Checks

  • If the issue is ready to work on, I have removed the "needs:info" label.
  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@diox
Copy link
Member Author

diox commented Sep 23, 2024

Minimal changes to the admin should be included to make it possible to test this.

Creating/editing has been left for later, for #15013, so to test this requires manually altering the blockversion in a shell. Still, you can test that all blocks are created as hard by default (the admin detail for a block now shows if each version in the block was soft or hard blocked)

@diox diox added this to the 2024.10.03 milestone Sep 23, 2024
@ioanarusiczki
Copy link

The only place I see this is when I go to Edit block

hardblock

I hope that's the expected for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:verified_fix repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants