Introduce the concept of soft-blocked versions, expose in the admin #22690
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
requested review from
a team and
eviljeff
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15012
Testing
You can add a block through
/en-US/admin/models/blocklist/blocklistsubmission/add/and verify that it's hard by default for all affected versions once created (this PR doesn't include a way to create soft-blocks using the admin) by either looking at the block in the admin after it's been created, or looking at theBlockVersioninstances in a shell.You can alter the
hardfield on theBlockVersioninstances to see how it affects the admin page for a given block (it should show up in theBlocked versions:part of the page).Further admin changes are planned but were not in scope for this specific ticket (that's mozilla/addons#15013)