Allow reviewers and developers to reply to older versions #22661
Conversation
diox
changed the title
| assert response.status_code == 404 | ||
|
|
||
| user = UserProfile.objects.get(username='reviewer') | ||
| self.grant_permission(user, 'Addons:ViewDeleted') |
There was a problem hiding this comment.
Removing the check on version being the latest version forced me to fix the test_reply_to_deleted_version_is_400 test below, which was expecting a 400... but it really should have expected a 404 instead. Digging further, I found that developers and reviewers without Addons:ViewDeleted were able to view activities on deleted versions, which was not consistent with every other API/view. So I fixed that, which in turn forced me to adjust a few more tests.
| {% set can_request_review=addon.can_request_review() %} | ||
| {% set can_cancel=(not addon.is_disabled and addon.status==amo.STATUS_NOMINATED) %} | ||
| {% if full_info and check_addon_ownership(request.user, addon, allow_developer=True) and version.channel == amo.CHANNEL_LISTED and (can_request_review or can_cancel) %} | ||
| {% if full_info and version.channel == amo.CHANNEL_LISTED and (can_request_review or can_cancel) and check_addon_ownership(request.user, addon, allow_developer=True) %} |
There was a problem hiding this comment.
We were redefining those 2 variables for each version, which is pointless and caused extra queries. I've moved their definition to the view.
| {% else %} | ||
| <div> | ||
| <a href="#" class="review-history-show" data-version="{{ latest_version_in_channel_including_disabled.id }}">{{ _('Leave a reply') }}</a> | ||
| </div> | ||
| {% endif %} |
There was a problem hiding this comment.
This part no longer makes sense since we're displaying the form on every version now.
… to be consistent
diox
force-pushed
the
allow-reviewer-replies-any-version
branch
from
5843736
to
bf4db19
Compare
* Allow reviewers and developers to reply to older versions
Fixes: mozilla/addons#1981