-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes to docker setup (logs, static file routing, healthcheck, dockerignore) #22679
Conversation
477ea1f
to
f5f4e5e
Compare
1380cdd
to
10d1844
Compare
10d1844
to
3150e09
Compare
Are these all the issues that are being fixed, and can you expand on the description? There are 5 commits, 4 sets of the testing instructions, but only 2 linked issues. (None of which seem to be about cleaning logs - can you update the PR title too) |
Several are indeed about logs. I didn't find any other tickets matching my commits. Added test set for the last commit. |
3150e09
to
a501bfe
Compare
a501bfe
to
9ea1f19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any affect from changes to start_period
- it took ~90 seconds to get to Healthy so I changed the start_period in docker-compose to 180 and it still took ~90 seconds 🤷
Fixes: mozilla/addons#15026
Description
Semi related small commits fixing several known bugs in our local dev setup
Context
I combined these for efficiency as it would be many tiny PRs that should be tested more or less in the same way.
Testing
Only log docker compose if specified in CI run-docker step check the CI for this PR in the failing steps there should be no long dumb of docker compose logs
Better and alphyabetized ignore paths for git and docker verify that files in the .dockerignore list are not included in the built image. Note: They will be included in the running container as we mount the entire root directory so test via running prod mode
make up
should never build.. hard to test but it won'tmake up
when containers are already up.make data_restore
works and doesn't fail with invalid index commandmake clean_docker
works and doesn't perform unnecessary logicChecklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.