Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTAP 2.0 does not always require UV in MakeCredentials #285

Merged
merged 1 commit into from
Aug 1, 2023
Merged

CTAP 2.0 does not always require UV in MakeCredentials #285

merged 1 commit into from
Aug 1, 2023

Conversation

jschanck
Copy link
Collaborator

Resolves #283

The functional change here is just the removal of || ... FIDO_2_0 from

let always_uv = info.options.always_uv == Some(true) || info.max_supported_version() == AuthenticatorVersion::FIDO_2_0;

@jschanck jschanck requested a review from mozkeeler July 31, 2023 22:00
mozkeeler
mozkeeler approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@jschanck jschanck merged commit 33f75ed into mozilla:ctap2-2021 Aug 1, 2023
8 checks passed
@riastradh riastradh mentioned this pull request Feb 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozkeeler mozkeeler mozkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FIDO_2_0 devices with no pin set - experiencing unexpected make credential behavior
2 participants
@jschanck @mozkeeler