Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle present-but-empty extension data when serializing AuthenticatorData #318

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Handle present-but-empty extension data when serializing AuthenticatorData #318

merged 1 commit into from
Nov 8, 2023

Conversation

jschanck
Copy link
Collaborator

@jschanck jschanck commented Nov 4, 2023

Resolves #317

@jschanck jschanck force-pushed the issue.317 branch 2 times, most recently from 0bbe6c0 to 8da8e2d Compare November 8, 2023 19:25
mozkeeler
mozkeeler approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@mozkeeler mozkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/ctap2/attestation.rs Outdated Show resolved Hide resolved
@jschanck jschanck merged commit be6526c into mozilla:ctap2-2021 Nov 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mozkeeler mozkeeler mozkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent Serialization/Deserialization Behavior with Empty Extension Data in attestation.rs
2 participants
@jschanck @mozkeeler