Skip to content

Commit

Permalink
Skipping copying checks for baseline tables for apps marked as not re…
Browse files Browse the repository at this point in the history
…ceiving the baseline ping (#4670)

Co-authored-by: Frank Bertsch <[email protected]>
  • Loading branch information
kik-kik and fbertsch authored Dec 11, 2023
1 parent 2db2f3e commit 6e2e8f6
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion sql_generators/glean_usage/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,24 @@
APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings"
PATH = Path(os.path.dirname(__file__))

# added as the result of baseline checks being added to the template,
# these apps do not receive a baseline ping causing a very basic row_count
# check to fail. For this reason, the checks relying on this ping
# need to be omitted. For more info see: bug-1868848
NO_BASELINE_PING_APPS = (
"mozilla_vpn",
"mozillavpn_cirrus",
"accounts_backend",
"burnham",
"firefox_reality_pc",
"lockwise_android",
"mach",
"monitor_cirrus",
"moso_mastodon_backend",
"mozphab",
"mozregression",
)


def write_dataset_metadata(output_dir, full_table_id, derived_dataset_metadata=False):
"""
Expand Down Expand Up @@ -283,7 +301,13 @@ def generate_per_app_id(
artifacts.append(Artifact(table, "init.sql", init_sql))

if checks_sql:
artifacts.append(Artifact(table, "checks.sql", checks_sql))
if "baseline" in table and app_name in NO_BASELINE_PING_APPS:
logging.info(
"Skipped copying ETL check for %s as app: %s is marked as not having baseline ping"
% (table, app_name)
)
else:
artifacts.append(Artifact(table, "checks.sql", checks_sql))

for artifact in artifacts:
destination = (
Expand Down

0 comments on commit 6e2e8f6

Please sign in to comment.