Properly fall back to error if token doesn't match

mozilla · Oct 31, 2024 · 08ccb2f · 08ccb2f
1 parent c2e3402
commit 08ccb2f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/db/tables/subscriber_email_preferences.ts b/src/db/tables/subscriber_email_preferences.ts
@@ -262,13 +262,13 @@ async function unsubscribeMonthlyMonitorReportForUnsubscribeToken(
     sub = await getEmailPreferenceForUnsubscribeToken(unsubscribeToken);
 
     if (
-      typeof sub.id === "number" &&
+      typeof sub?.id === "number" &&
       sub.monthly_monitor_report_free === false
     ) {
       logger.info(
         "unsubscribe_monthly_monitor_report_for_unsubscribe_token_already_unsubscribed",
       );
-    } else if (typeof sub.id === "number") {
+    } else if (typeof sub?.id === "number") {
       await updateEmailPreferenceForSubscriber(sub.id, true, {
         monthly_monitor_report_free: false,
       });