rename func

mozilla · Oct 28, 2024 · e867bb9 · e867bb9
1 parent 57decbc
commit e867bb9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 10 deletions.
diff --git a/src/emails/components/EmailDataPointCount.tsx b/src/emails/components/EmailDataPointCount.tsx
@@ -10,7 +10,7 @@ import { DashboardSummary } from "../../app/functions/server/dashboard";
 import { getSignupLocaleCountry } from "../functions/getSignupLocaleCountry";
 import { isEligibleForPremium } from "../../app/functions/universal/premium";
 import { SanitizedSubscriberRow } from "../../app/functions/server/sanitize";
-import { calculateSanitizedDataPoints } from "../functions/reduceSanitizedDataPoints";
+import { sumSanitizedDataPoints } from "../functions/reduceSanitizedDataPoints";
 
 type Props = {
   l10n: ExtendedReactLocalization;
@@ -66,7 +66,7 @@ export const DataPointCount = (props: Props) => {
             line-height="68px"
           >
             {hasRunFreeScan
-              ? calculateSanitizedDataPoints(
+              ? sumSanitizedDataPoints(
                   props.dataSummary.unresolvedSanitizedDataPoints,
                 )
               : unresolvedDataBreaches}
@@ -84,7 +84,7 @@ export const DataPointCount = (props: Props) => {
                   : "email-monthly-report-no-scan-results-data-points-label",
                 {
                   data_point_count: hasRunFreeScan
-                    ? calculateSanitizedDataPoints(
+                    ? sumSanitizedDataPoints(
                         props.dataSummary.unresolvedSanitizedDataPoints,
                       )
                     : unresolvedDataBreaches,

diff --git a/src/emails/functions/reduceSanitizedDataPoints.ts b/src/emails/functions/reduceSanitizedDataPoints.ts
@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 // data is inteferred from the SanitizedDataPoints type, but we ran into inference issues directly importing it
-export function calculateSanitizedDataPoints(
+export function sumSanitizedDataPoints(
   data: Array<Record<string, number>>,
 ): number {
   return data.reduce((accumulatedValue, currentDataPoint) => {

diff --git a/src/emails/templates/monthlyActivityFree/MonthlyActivityFreeEmail.tsx b/src/emails/templates/monthlyActivityFree/MonthlyActivityFreeEmail.tsx
@@ -13,7 +13,7 @@ import { isEligibleForPremium } from "../../../app/functions/universal/premium";
 import { getSignupLocaleCountry } from "../../functions/getSignupLocaleCountry";
 import { HeaderStyles, MetaTags } from "../HeaderStyles";
 import { SanitizedSubscriberRow } from "../../../app/functions/server/sanitize";
-import { calculateSanitizedDataPoints } from "../../functions/reduceSanitizedDataPoints";
+import { sumSanitizedDataPoints } from "../../functions/reduceSanitizedDataPoints";
 
 export type MonthlyActivityFreeEmailProps = {
   l10n: ExtendedReactLocalization;
@@ -79,16 +79,15 @@ export const MonthlyActivityFreeEmail = (
     // Show a sum of resolved data breach & broker exposures if a scan has been run
     // Otherwise, only show resolved data breaches
     dataPointValue: hasRunFreeScan
-      ? calculateSanitizedDataPoints(props.dataSummary.fixedSanitizedDataPoints)
+      ? sumSanitizedDataPoints(props.dataSummary.fixedSanitizedDataPoints)
       : props.dataSummary.dataBreachResolvedNum,
     // The resolved box would be active if
     // a user has run a free scan and they have resolved data breaches, and or brokers (count number of resolved data points)
     // if a user hasn't run a free scan but they have resolved data breaches (count number of resolved breach cards)
     activeState:
       (hasRunFreeScan &&
-        calculateSanitizedDataPoints(
-          props.dataSummary.fixedSanitizedDataPoints,
-        ) > 0) ||
+        sumSanitizedDataPoints(props.dataSummary.fixedSanitizedDataPoints) >
+          0) ||
       (!hasRunFreeScan && props.dataSummary.dataBreachResolvedNum > 0),
   };
 
@@ -99,7 +98,7 @@ export const MonthlyActivityFreeEmail = (
     preScan: !hasRunFreeScan && props.dataSummary.dataBreachUnresolvedNum === 0,
     postScan:
       hasRunFreeScan &&
-      calculateSanitizedDataPoints(
+      sumSanitizedDataPoints(
         props.dataSummary.unresolvedSanitizedDataPoints,
       ) === 0,
   };