chore: Only set max failures for E2E tests that are running on PRs

mozilla · Sep 28, 2024 · f08483e · f08483e
1 parent fe0b9b0
commit f08483e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/e2e_cron.yml b/.github/workflows/e2e_cron.yml
@@ -76,7 +76,7 @@ jobs:
           name: test-results
           path: src/e2e/test-results/
           retention-days: 30
-          
+
       - name: Send GitHub Action trigger data to Slack workflow
         id: slack
         uses: slackapi/[email protected]

diff --git a/.github/workflows/e2e_pr_full.yml b/.github/workflows/e2e_pr_full.yml
@@ -59,7 +59,7 @@ jobs:
 
       - name: Run Playwright tests
         if: github.actor != 'dependabot[bot]'
-        run: npm run e2e -- --update-snapshots
+        run: npm run e2e -- --max-failures=1 --update-snapshots
         timeout-minutes: 20
         env:
           E2E_TEST_ENV: local

diff --git a/playwright.config.js b/playwright.config.js
@@ -50,9 +50,6 @@ export default defineConfig({
   /* Fail the build on CI if you accidentally left test.only in the source code. */
   forbidOnly: !!process.env.CI,
 
-  /* Limit the number of failures */
-  maxFailures: 1,
-
   /* Retry on CI only */
   retries: process.env.CI ? 1 : 0,